Fix getKeysUsingKeySpecs keynum case ignoring keystep when calc the last key#3197
Merged
Merged
Conversation
…ast key This issue was encountered while processing valkey-io#3121. Currently in all our commands with KSPEC_FK_KEYNUM, key step is 1. So this bug does not currently affect any core commands. If we have commands with different key step values, calculting the last key in here will casue problems since we are not including step in the calculation. Signed-off-by: Binbin <binloveplay1314@qq.com>
zuiderkwast
approved these changes
Feb 13, 2026
Nikhil-Manglore
approved these changes
Feb 16, 2026
madolson
approved these changes
Feb 16, 2026
madolson
left a comment
Member
There was a problem hiding this comment.
I couldn't find any modules impacted by this.
ranshid
approved these changes
Feb 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3197 +/- ##
================================
================================
🚀 New features to boost your workflow:
|
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
…ast key (valkey-io#3197) This issue was encountered while processing valkey-io#3121. Currently in all our commands with KSPEC_FK_KEYNUM, key step is 1. So this bug does not currently affect any core commands. If we have commands with different key step values, calculting the last key in here will casue problems since we are not including step in the calculation. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was encountered while processing #3121. Currently in all our
commands with KSPEC_FK_KEYNUM, key step is 1. So this bug does not currently
affect any core commands.
If we have commands with different key step values, calculting the last key
in here will casue problems since we are not including step in the calculation.