Skip flaky test cases in client-eviction.tcl when in TLS mode#3151
Merged
Conversation
Signed-off-by: Zhijun <dszhijun@gmail.com>
Contributor
Author
|
cc @zuiderkwast |
zuiderkwast
approved these changes
Feb 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3151 +/- ##
============================================
+ Coverage 74.83% 74.91% +0.08%
============================================
Files 129 129
Lines 71208 71208
============================================
+ Hits 53292 53349 +57
+ Misses 17916 17859 -57 🚀 New features to boost your workflow:
|
enjoy-binbin
approved these changes
Feb 2, 2026
sarthakaggarwal97
approved these changes
Feb 2, 2026
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 3, 2026
…-io#3151) Closes valkey-io#3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 4, 2026
…-io#3151) Closes valkey-io#3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 4, 2026
…-io#3151) Closes valkey-io#3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 4, 2026
…-io#3151) Closes valkey-io#3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 18, 2026
…-io#3151) Closes valkey-io#3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 19, 2026
…-io#3151) Closes valkey-io#3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
…-io#3151) Closes valkey-io#3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 20, 2026
…-io#3151) Closes valkey-io#3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
hpatro
pushed a commit
that referenced
this pull request
Feb 24, 2026
Closes #3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
madolson
pushed a commit
that referenced
this pull request
Feb 24, 2026
Closes #3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
madolson
pushed a commit
that referenced
this pull request
Feb 24, 2026
Closes #3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
…-io#3151) Closes valkey-io#3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 16, 2026
The 'client evicted due to percentage of maxmemory' test fails intermittently under TLS because TLS buffer overhead changes memory accounting, causing the tot-mem assertion to fail. Same pattern as the other two tls:skip tags added by valkey-io#3151. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 23, 2026
…-io#3151) Closes valkey-io#3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 27, 2026
…-io#3151) Closes valkey-io#3146 The following two test cases are flaky - `evict clients only until below limit` - uses exact math expecting exactly half the clients evicted - `evict clients in right order (large to small)` - uses exact math expecting specific clients evicted in order It's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS. The `decrease maxmemory-clients causes client eviction` test case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion: `connected_clients > 0 && connected_clients < $client_count`, I think it's okay not to bother skipping it. Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts. Signed-off-by: Zhijun <dszhijun@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com> (cherry picked from commit 89f221f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3146
The following two test cases are flaky
evict clients only until below limit- uses exact math expecting exactly half the clients evictedevict clients in right order (large to small)- uses exact math expecting specific clients evicted in orderIt's fine to skip them in TLS because the core logic being tested (client eviction) doesn't change based on TLS vs non-TLS.
The
decrease maxmemory-clients causes client evictiontest case could potentially be flaky as well (has not shown flakiness on CI yet), but since it has more tolerant assertion:connected_clients > 0 && connected_clients < $client_count, I think it's okay not to bother skipping it.Other test cases are not flaky because they use large thresholds or check binary outcomes (yes/no eviction), not exact counts.