Revert #3088#3137
Merged
Merged
Conversation
valkey-io#3088)" This reverts commit 2e2eb41. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
633f8a6 to
b08e46b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3137 +/- ##
============================================
+ Coverage 74.72% 74.96% +0.23%
============================================
Files 129 129
Lines 71199 71197 -2
============================================
+ Hits 53205 53371 +166
+ Misses 17994 17826 -168
🚀 New features to boost your workflow:
|
enjoy-binbin
approved these changes
Jan 30, 2026
PingXie
approved these changes
Jan 30, 2026
immangat
pushed a commit
to immangat/valkey
that referenced
this pull request
Feb 1, 2026
Reverts "Fix the memory leak in the VM_GetCommandKeysWithFlags function (valkey-io#3088)" This reverts commit 2e2eb41. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Member
|
Do we need to find someone to fix it? I know the details when i reviewed the PR, people is able to know the details just read the top comment. |
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
Reverts "Fix the memory leak in the VM_GetCommandKeysWithFlags function (valkey-io#3088)" This reverts commit 2e2eb41. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
Reverts "Fix the memory leak in the VM_GetCommandKeysWithFlags function (valkey-io#3088)" This reverts commit 2e2eb41. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
madolson
added a commit
to madolson/valkey
that referenced
this pull request
Mar 15, 2026
- Fix release date to Mon Mar 18 2026 - Fix typos: duplicate 'load', 'keyes' -> 'keys', duplicate 'INFO' - Remove reverted contributor (arshidkv12, valkey-io#3137) - Add 7 new release-notes entries from upstream/unstable merge: CLUSTERSCAN (valkey-io#2934), MSETEX (valkey-io#3121), availability-zone (valkey-io#3156), stream range optimization (valkey-io#3002), RDB as AOF preamble (valkey-io#1901), unsigned 64-bit module config (valkey-io#1546), fast_float -> ffc (valkey-io#3329) Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts "Fix the memory leak in the VM_GetCommandKeysWithFlags function (#3088)"
This reverts commit 2e2eb41.