Skip active io time test if valgrind is used#3124
Merged
Merged
Conversation
zuiderkwast
reviewed
Jan 29, 2026
9032658 to
e1dfb60
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3124 +/- ##
============================================
- Coverage 74.87% 74.81% -0.07%
============================================
Files 129 129
Lines 71199 71199
============================================
- Hits 53310 53264 -46
- Misses 17889 17935 +46 🚀 New features to boost your workflow:
|
Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
e1dfb60 to
ef2696d
Compare
zuiderkwast
approved these changes
Jan 29, 2026
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
OK, great, thanks!
Maybe in the future, we can make it possible to use skip directy under start_server, or to introduce a tag valgrind:skip to make it possible to skip before even before starting a server. We have a few more skipped test cases for valgrind that could use a tag like that.
Member
Author
|
Created issue for that, definitely a good idea! |
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
If valgrind is used then test for used_active_time_io_thread fails
because valgrind is slow, so skip it
```
[err]: Force the use of IO threads and assert active IO thread usage in tests/unit/io-threads.tcl
Expected (7.941596 - 5.876588) < (1000/1000) (context: type eval line 53 cmd {assert {($used_active_time - $initial_active_times($i)) < ($sleep_time_ms/1000)}} proc ::test)
```
Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
If valgrind is used then test for used_active_time_io_thread fails
because valgrind is slow, so skip it
```
[err]: Force the use of IO threads and assert active IO thread usage in tests/unit/io-threads.tcl
Expected (7.941596 - 5.876588) < (1000/1000) (context: type eval line 53 cmd {assert {($used_active_time - $initial_active_times($i)) < ($sleep_time_ms/1000)}} proc ::test)
```
Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
Taeknology
added a commit
to Taeknology/valkey
that referenced
this pull request
May 19, 2026
The delta-from-initial-baseline assertion measures cumulative active time across the entire test (toggle + sleep + final activation). As the monotonic counter (src/io_threads.c:27) accumulates, this bound is fragile: PR valkey-io#3124 had to add valgrind:skip after the same form failed under valgrind. The remaining delta-from-pre-sleep assertion covers the real invariant — io_threads should idle during sleep and only the final reactivation contributes to the post-sleep delta. Addresses review feedback on valkey-io#3764. Signed-off-by: Taeknology <20297177+Taeknology@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If valgrind is used then test for used_active_time_io_thread fails because valgrind is slow, so skip it