Skip to content

Comment cleanup around entry.c file#3107

Merged
enjoy-binbin merged 1 commit into
valkey-io:unstablefrom
enjoy-binbin:entry_cleanup
Jan 25, 2026
Merged

Comment cleanup around entry.c file#3107
enjoy-binbin merged 1 commit into
valkey-io:unstablefrom
enjoy-binbin:entry_cleanup

Conversation

@enjoy-binbin

Copy link
Copy Markdown
Member

Fix some outdated comments, improved some comments.

Fix some outdated comments, improved some comments.

Signed-off-by: Binbin <binloveplay1314@qq.com>
@codecov

codecov Bot commented Jan 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.28%. Comparing base (278607b) to head (ed2fb69).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #3107      +/-   ##
============================================
- Coverage     74.38%   74.28%   -0.11%     
============================================
  Files           129      129              
  Lines         71041    71043       +2     
============================================
- Hits          52844    52773      -71     
- Misses        18197    18270      +73     
Files with missing lines Coverage Δ
src/entry.c 80.26% <100.00%> (+0.17%) ⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvkashapov dvkashapov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ranshid ranshid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this!

@enjoy-binbin enjoy-binbin merged commit e7d004b into valkey-io:unstable Jan 25, 2026
25 checks passed
@enjoy-binbin enjoy-binbin deleted the entry_cleanup branch January 25, 2026 12:08
harrylin98 pushed a commit to harrylin98/valkey_forked that referenced this pull request Feb 19, 2026
Fix some outdated comments, improved some comments.

Signed-off-by: Binbin <binloveplay1314@qq.com>
hpatro pushed a commit to hpatro/valkey that referenced this pull request Mar 5, 2026
Fix some outdated comments, improved some comments.

Signed-off-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants