Make CMake test also run tls tests#3097
Merged
Merged
Conversation
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3097 +/- ##
============================================
+ Coverage 74.35% 74.37% +0.02%
============================================
Files 129 129
Lines 71013 71013
============================================
+ Hits 52803 52819 +16
+ Misses 18210 18194 -16 🚀 New features to boost your workflow:
|
enjoy-binbin
approved these changes
Jan 22, 2026
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
We are already double running the tests with CMake, and we are building CMake with TLS, so just making it so we run the tests with TLS. This seems like an simple update so that we are always running the TLS tests. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
We are already double running the tests with CMake, and we are building CMake with TLS, so just making it so we run the tests with TLS. This seems like an simple update so that we are always running the TLS tests. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are already double running the tests with CMake, and we are building CMake with TLS, so just making it so we run the tests with TLS. This seems like an simple update so that we are always running the TLS tests.
Can wait until after #3094 is merged so the CI is green.