Fix weekly workflow to continue after failure in releases branches#3082
Conversation
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3082 +/- ##
============================================
- Coverage 74.41% 74.25% -0.17%
============================================
Files 129 129
Lines 71009 71009
============================================
- Hits 52844 52728 -116
- Misses 18165 18281 +116 🚀 New features to boost your workflow:
|
roshkhatri
left a comment
There was a problem hiding this comment.
Looks good to me, Also why does the workflow only run for 7.2 branch?
Is it because fail-fast?
|
@roshkhatri yes. I have set the |
|
Oh got it, cause of |
To avoid blocking all the github runners. Might block CI runs for the PRs I guess. |
|
If we remove the |
|
I mean we are anyway blocking the runners with the 40-45 wfs, and once any of them finishes then the CI will be given runners. |
Nikhil-Manglore
left a comment
There was a problem hiding this comment.
I think this is a good change to have
…alkey-io#3082) Currently, the weekly runs do not progress if there is a failed workflow as github CI treats `fail-fast` to be true by default. With this change, we continue to test all the branches even after failure. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: arshidkv12 <arshidkv12@gmail.com>
…alkey-io#3082) Currently, the weekly runs do not progress if there is a failed workflow as github CI treats `fail-fast` to be true by default. With this change, we continue to test all the branches even after failure. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
…alkey-io#3082) Currently, the weekly runs do not progress if there is a failed workflow as github CI treats `fail-fast` to be true by default. With this change, we continue to test all the branches even after failure. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
Currently, the weekly runs do not progress if there is a failed workflow as github CI treats
fail-fastto be true by default. With this change, we continue to test all the branches even after failure.Last week's run: https://github.com/valkey-io/valkey/actions/runs/21107098709
Documentation on fail-fast: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idstrategyfail-fast