Skip to content

improve format for hashtableDump#3081

Merged
zuiderkwast merged 1 commit into
valkey-io:unstablefrom
JimB123:hashtable-debug
Jan 20, 2026
Merged

improve format for hashtableDump#3081
zuiderkwast merged 1 commit into
valkey-io:unstablefrom
JimB123:hashtable-debug

Conversation

@JimB123

@JimB123 JimB123 commented Jan 20, 2026

Copy link
Copy Markdown
Member

Simple change to hashtableDebug to improve readability:

  • Improve indentation
  • Remove "(empty)" lines

Signed-off-by: Jim Brunner <brunnerj@amazon.com>
@codecov

codecov Bot commented Jan 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.26%. Comparing base (8fdc9e6) to head (760dbee).
⚠️ Report is 2 commits behind head on unstable.

Files with missing lines Patch % Lines
src/hashtable.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #3081      +/-   ##
============================================
- Coverage     74.41%   74.26%   -0.16%     
============================================
  Files           129      129              
  Lines         71009    71007       -2     
============================================
- Hits          52844    52732     -112     
- Misses        18165    18275     +110     
Files with missing lines Coverage Δ
src/hashtable.c 89.28% <0.00%> (+0.18%) ⬆️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zuiderkwast zuiderkwast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

It doesn't seem to be used anywhere, not even in tests. I guess it's only for debugging/exploring.

@zuiderkwast zuiderkwast merged commit 1084e67 into valkey-io:unstable Jan 20, 2026
25 checks passed
arshidkv12 pushed a commit to arshidkv12/valkey that referenced this pull request Jan 23, 2026
Simple change to `hashtableDebug` to improve readability:
* Improve indentation
* Remove "(empty)" lines

Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: arshidkv12 <arshidkv12@gmail.com>
harrylin98 pushed a commit to harrylin98/valkey_forked that referenced this pull request Feb 19, 2026
Simple change to `hashtableDebug` to improve readability:
* Improve indentation
* Remove "(empty)" lines

Signed-off-by: Jim Brunner <brunnerj@amazon.com>
hpatro pushed a commit to hpatro/valkey that referenced this pull request Mar 5, 2026
Simple change to `hashtableDebug` to improve readability:
* Improve indentation
* Remove "(empty)" lines

Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants