Add copilot review instructions#3076
Merged
Merged
Conversation
Signed-off-by: Ping Xie <pingxie@outlook.com>
494f746 to
2d2a638
Compare
Signed-off-by: Ping Xie <pingxie@outlook.com>
Signed-off-by: Ping Xie <pingxie@outlook.com>
Signed-off-by: Ping Xie <pingxie@outlook.com>
Signed-off-by: Ping Xie <pingxie@outlook.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3076 +/- ##
============================================
- Coverage 74.33% 74.18% -0.15%
============================================
Files 129 129
Lines 71009 71009
============================================
- Hits 52784 52680 -104
- Misses 18225 18329 +104 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds GitHub Copilot review integration by introducing a workflow trigger and a comprehensive instruction set document that defines code review standards for AI-assisted reviews.
Changes:
- Added a GitHub Actions workflow that triggers on pushes to the
unstablebranch and pull request events to signal for AI code review - Created a detailed instructions document that consolidates Valkey project's coding standards, contribution requirements, governance policies, and review escalation procedures for AI consumption
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/copilot-review.yml | Defines the workflow trigger for Copilot reviews with concurrency controls and event handling |
| .github/copilot-instructions.md | Provides comprehensive AI review guidelines covering coding style, testing, security, governance, and escalation procedures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3abef97 to
10a4131
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a0597e4 to
964bb5c
Compare
Add repository-wide and path-specific instructions to guide Copilot code reviews with actionable feedback on code quality, safety, and project standards. General instructions focus on what Copilot can check and comment on: - DCO sign-off presence in commits - Security vulnerability handling (flag public PRs) - Major decision detection (mention @core-team for TSC review) - Documentation and issue linking reminders - Governance file change detection (mention @core-team) Code-specific instructions in three scoped files: - core-engine: C code standards, safety, testing, command JSON updates Critical file changes mention @core-team for architectural review - integration-tests: Tcl test organization and practices - utils: Script standards for Python/Ruby/Shell/C tools Copilot can mention teams/users in comments but cannot add labels, request reviews via GitHub API, or enforce approval requirements. Signed-off-by: Ping Xie <pingxie@outlook.com>
f28c4ec to
127802b
Compare
zuiderkwast
approved these changes
Jan 20, 2026
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
I didn't review it very carefully, but it can't break anything. Let's merge this so can try it out. We can change it again later when we want.
arshidkv12
pushed a commit
to arshidkv12/valkey
that referenced
this pull request
Jan 23, 2026
Signed-off-by: Ping Xie <pingxie@outlook.com> Signed-off-by: arshidkv12 <arshidkv12@gmail.com>
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Ping Xie <pingxie@outlook.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
Signed-off-by: Ping Xie <pingxie@outlook.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.