Skip to content

Add test for mptcp#3042

Merged
zuiderkwast merged 1 commit into
valkey-io:unstablefrom
wxmzy88:unstable
Jan 20, 2026
Merged

Add test for mptcp#3042
zuiderkwast merged 1 commit into
valkey-io:unstablefrom
wxmzy88:unstable

Conversation

@wxmzy88

@wxmzy88 wxmzy88 commented Jan 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add test for mptcp

Signed-off-by: wangxiaomeng wangxiaomeng@kylinos.cn

@Nikhil-Manglore

Nikhil-Manglore commented Jan 13, 2026

Copy link
Copy Markdown
Member

Doesn't look like the DCO was signed off correctly, you can follow these steps here: https://github.com/valkey-io/valkey/pull/3042/checks?check_run_id=60077918276

@wxmzy88 wxmzy88 force-pushed the unstable branch 3 times, most recently from 248afa6 to f05a567 Compare January 14, 2026 01:24
@wxmzy88

wxmzy88 commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

Doesn't look like the DCO was signed off correctly, you can follow these steps here: https://github.com/valkey-io/valkey/pull/3042/checks?check_run_id=60077918276

Fixed. Please review it again, thanks.

zuiderkwast
zuiderkwast reviewed Jan 16, 2026
View reviewed changes

@zuiderkwast zuiderkwast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Thanks.

Comment thread tests/unit/mptcp.tcl Outdated
Comment thread tests/unit/mptcp.tcl Outdated
@zuiderkwast

zuiderkwast commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

Question: Is the test client in TCL using MPTCP? I think maybe it's just using a regular TCP connection.

@wxmzy88
Add test for mptcp
7041d3e 
Signed-off-by: wangxiaomeng <wangxiaomeng@kylinos.cn>
@wxmzy88

wxmzy88 commented Jan 20, 2026

Copy link
Copy Markdown
Contributor Author

Question: Is the test client in TCL using MPTCP? I think maybe it's just using a regular TCP connection.

You're right. The test itself does not directly force the TCL client [r] to use an MPTCP socket.

What the test actually verifies is:

  1. That the valkey server starts successfully with the mptcp yes configuration.
  2. That the server's basic command handling remains functional under this configuration.

zuiderkwast
zuiderkwast approved these changes Jan 20, 2026
View reviewed changes

@zuiderkwast zuiderkwast left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Later, we could also add a test with a real MPTCP connection using valkey-cli --mptcp. I don't know how we can actually verify that the connection is using MPTCP though. Maybe it's only visible in WireShark or similar.

@codecov

codecov Bot commented Jan 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.30%. Comparing base (35fdcea) to head (7041d3e).
⚠️ Report is 20 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #3042      +/-   ##
============================================
- Coverage     74.38%   74.30%   -0.09%     
============================================
  Files           129      129              
  Lines         70972    71009      +37     
============================================
- Hits          52791    52761      -30     
- Misses        18181    18248      +67

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zuiderkwast zuiderkwast merged commit 2883c6a into valkey-io:unstable Jan 20, 2026
24 checks passed
enjoy-binbin
enjoy-binbin reviewed Jan 21, 2026
View reviewed changes

@enjoy-binbin enjoy-binbin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My local Mac does not support MPTCP, we need to find a way that can skip the test in some OS.

@zuiderkwast

zuiderkwast commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Good point. We should skip it in the same way we skip ipv6 tests if it's not available. The test is tagged with mptcp.

@zuiderkwast zuiderkwast mentioned this pull request Jan 21, 2026
Merged
zuiderkwast added a commit that referenced this pull request Jan 21, 2026
@zuiderkwast
Skip MPTCP test on platforms without MPTCP (#3089)
c1b4129 
The test case added in #3042 fails on platforms without MPTCP support.

This change automatically skips the MPTCP tests on platforms without
MTPCP.

---------

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
arshidkv12 pushed a commit to arshidkv12/valkey that referenced this pull request Jan 23, 2026
@wxmzy88 @arshidkv12
Add test for MPTCP (valkey-io#3042)
29ecbf7 
Signed-off-by: wangxiaomeng <wangxiaomeng@kylinos.cn>
Signed-off-by: arshidkv12 <arshidkv12@gmail.com>
arshidkv12 pushed a commit to arshidkv12/valkey that referenced this pull request Jan 23, 2026
@zuiderkwast @arshidkv12
Skip MPTCP test on platforms without MPTCP (valkey-io#3089)
0869a27 
The test case added in valkey-io#3042 fails on platforms without MPTCP support.

This change automatically skips the MPTCP tests on platforms without
MTPCP.

---------

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: arshidkv12 <arshidkv12@gmail.com>
harrylin98 pushed a commit to harrylin98/valkey_forked that referenced this pull request Feb 19, 2026
@wxmzy88
Add test for MPTCP (valkey-io#3042)
0c987b6 
Signed-off-by: wangxiaomeng <wangxiaomeng@kylinos.cn>
harrylin98 pushed a commit to harrylin98/valkey_forked that referenced this pull request Feb 19, 2026
@zuiderkwast
Skip MPTCP test on platforms without MPTCP (valkey-io#3089)
3db1768 
The test case added in valkey-io#3042 fails on platforms without MPTCP support.

This change automatically skips the MPTCP tests on platforms without
MTPCP.

---------

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
hpatro pushed a commit to hpatro/valkey that referenced this pull request Mar 5, 2026
@wxmzy88 @hpatro
Add test for MPTCP (valkey-io#3042)
724410d 
Signed-off-by: wangxiaomeng <wangxiaomeng@kylinos.cn>
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
hpatro pushed a commit to hpatro/valkey that referenced this pull request Mar 5, 2026
@zuiderkwast @hpatro
Skip MPTCP test on platforms without MPTCP (valkey-io#3089)
0206b0b 
The test case added in valkey-io#3042 fails on platforms without MPTCP support.

This change automatically skips the MPTCP tests on platforms without
MTPCP.

---------

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enjoy-binbin enjoy-binbin enjoy-binbin left review comments
@zuiderkwast zuiderkwast zuiderkwast approved these changes

Assignees

@wxmzy88 wxmzy88

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wxmzy88 @Nikhil-Manglore @zuiderkwast @enjoy-binbin