Fixing a lua debugger bug that prevented use of 'server' for server.call invocations.#303
Merged
Conversation
…all invocations. * Tested it on local instance. This was originally part of #288 but I am pushing this separately, so that we can easily merge it into the upcoming release. ``` lua debugger> server ping <redis> ping <reply> "+PONG" lua debugger> redis ping <redis> ping <reply> "+PONG" ``` Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
…y well but tried to implement as close to the patterns in the file as possible. Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
madolson
approved these changes
Apr 11, 2024
madolson
left a comment
Member
There was a problem hiding this comment.
OK, played around with it a bunch and I think this seems good.
madolson
pushed a commit
that referenced
this pull request
Apr 11, 2024
…all invocations. (#303) * Tested it on local instance. This was originally part of #288 but I am pushing this separately, so that we can easily merge it into the upcoming release. ``` lua debugger> server ping <redis> ping <reply> "+PONG" lua debugger> redis ping <redis> ping <reply> "+PONG" ``` * I also searched for lua debugger related unit tests to add coverage for this but did not find any relevant test to modify. Leaving it at that for now. --------- Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
zuiderkwast
pushed a commit
to zuiderkwast/valkey
that referenced
this pull request
Apr 17, 2024
…all invocations. (valkey-io#303) * Tested it on local instance. This was originally part of valkey-io#288 but I am pushing this separately, so that we can easily merge it into the upcoming release. ``` lua debugger> server ping <redis> ping <reply> "+PONG" lua debugger> redis ping <redis> ping <reply> "+PONG" ``` * I also searched for lua debugger related unit tests to add coverage for this but did not find any relevant test to modify. Leaving it at that for now. --------- Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
…all invocations. (valkey-io#303) * Tested it on local instance. This was originally part of valkey-io#288 but I am pushing this separately, so that we can easily merge it into the upcoming release. ``` lua debugger> server ping <redis> ping <reply> "+PONG" lua debugger> redis ping <redis> ping <reply> "+PONG" ``` * I also searched for lua debugger related unit tests to add coverage for this but did not find any relevant test to modify. Leaving it at that for now. --------- Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
zuiderkwast
pushed a commit
that referenced
this pull request
May 13, 2026
Squashed 'deps/libvalkey/' changes from 45c2ed15c..cb5ff91aa cb5ff91aa Release 0.5.0 cd3d5d8ff Fix potential heap-buffer-overflow in cluster error reply parsing (#305) 32c7c5d09 Refactor error handling to use valkeySetErrorFromErrno and valkeyClearError (#303) e4b548b32 Remove support for external dict while still supporting external sds (#302) 61b27c453 Try all addresses from DNS before failing to connect (#300) 8aff94fab RDMA: Fix lost EPOLLIN/POLLIN events b9285b5fc Optimize read buffer compaction and reduce copying (#294) 0fa809877 Additional overflow protection for MAP/ATTR b26c56e87 Fix gcc warnings (#287) git-subtree-dir: deps/libvalkey git-subtree-split: cb5ff91aa5816807f0a549bd2b36e611253dfeb6 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
lucasyonge
pushed a commit
that referenced
this pull request
May 14, 2026
Squashed 'deps/libvalkey/' changes from 45c2ed15c..cb5ff91aa cb5ff91aa Release 0.5.0 cd3d5d8ff Fix potential heap-buffer-overflow in cluster error reply parsing (#305) 32c7c5d09 Refactor error handling to use valkeySetErrorFromErrno and valkeyClearError (#303) e4b548b32 Remove support for external dict while still supporting external sds (#302) 61b27c453 Try all addresses from DNS before failing to connect (#300) 8aff94fab RDMA: Fix lost EPOLLIN/POLLIN events b9285b5fc Optimize read buffer compaction and reduce copying (#294) 0fa809877 Additional overflow protection for MAP/ATTR b26c56e87 Fix gcc warnings (#287) git-subtree-dir: deps/libvalkey git-subtree-split: cb5ff91aa5816807f0a549bd2b36e611253dfeb6 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.