makefile formatting: split lists onto multiple lines for better readability and easier merging#3015
Merged
Conversation
…merging. Signed-off-by: Rain Valentine <rsg000@gmail.com>
hpatro
approved these changes
Jan 7, 2026
hpatro
left a comment
Contributor
There was a problem hiding this comment.
Thank you @rainsupreme. I had to deal with a merge conflict as well recently around the Makefile. This is super helpful.
madolson
reviewed
Jan 9, 2026
madolson
reviewed
Jan 9, 2026
madolson
reviewed
Jan 9, 2026
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3015 +/- ##
============================================
+ Coverage 74.29% 74.30% +0.01%
============================================
Files 129 129
Lines 70974 71041 +67
============================================
+ Hits 52731 52788 +57
- Misses 18243 18253 +10 🚀 New features to boost your workflow:
|
zuiderkwast
approved these changes
Jan 12, 2026
zuiderkwast
reviewed
Jan 22, 2026
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
zuiderkwast
reviewed
Jan 22, 2026
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
zuiderkwast
reviewed
Jan 22, 2026
Signed-off-by: Rain Valentine <rsg000@gmail.com>
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
…bility and easier merging (valkey-io#3015) These lists are getting longer recently, and they're annoying to edit. I recently did a lot of rebasing and got tired of it. 😅 --------- Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
…bility and easier merging (valkey-io#3015) These lists are getting longer recently, and they're annoying to edit. I recently did a lot of rebasing and got tired of it. 😅 --------- Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These lists are getting longer recently, and they're annoying to edit. I recently did a lot of rebasing and got tired of it. 😅