fix the failing warmup and duration are cumulative#2854
Merged
Conversation
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2854 +/- ##
============================================
- Coverage 72.44% 72.42% -0.02%
============================================
Files 128 128
Lines 70371 70371
============================================
- Hits 50977 50965 -12
- Misses 19394 19406 +12 🚀 New features to boost your workflow:
|
sarthakaggarwal97
approved these changes
Nov 17, 2025
JimB123
approved these changes
Nov 17, 2025
zuiderkwast
approved these changes
Nov 17, 2025
rainsupreme
approved these changes
Nov 19, 2025
rainsupreme
left a comment
Contributor
There was a problem hiding this comment.
certainly fine for a quick fix! 👍
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 28, 2025
We need to verify total duration was at least 2 seconds, elapsed time can be quite variable to check upper-bound Fixes valkey-io#2843 Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 28, 2025
We need to verify total duration was at least 2 seconds, elapsed time can be quite variable to check upper-bound Fixes valkey-io#2843 Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 28, 2025
We need to verify total duration was at least 2 seconds, elapsed time can be quite variable to check upper-bound Fixes valkey-io#2843 Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
jjuleslasarte
pushed a commit
to jjuleslasarte/valkey
that referenced
this pull request
Jan 6, 2026
We need to verify total duration was at least 2 seconds, elapsed time can be quite variable to check upper-bound Fixes valkey-io#2843 Signed-off-by: Roshan Khatri <rvkhatri@amazon.com> Signed-off-by: jjuleslasarte <jules.lasarte@gmail.com>
jjuleslasarte
pushed a commit
to jjuleslasarte/valkey
that referenced
this pull request
Jan 6, 2026
We need to verify total duration was at least 2 seconds, elapsed time can be quite variable to check upper-bound Fixes valkey-io#2843 Signed-off-by: Roshan Khatri <rvkhatri@amazon.com> Signed-off-by: jjuleslasarte <jules.lasarte@gmail.com>
jdheyburn
pushed a commit
to jdheyburn/valkey
that referenced
this pull request
Jan 8, 2026
We need to verify total duration was at least 2 seconds, elapsed time can be quite variable to check upper-bound Fixes valkey-io#2843 Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
We need to verify total duration was at least 2 seconds, elapsed time can be quite variable to check upper-bound Fixes valkey-io#2843 Signed-off-by: Roshan Khatri <rvkhatri@amazon.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to verify total duration was at least 2 seconds, elapsed time can be quite variable to check upper-bound
fixes #2843