[flaky-failure-fix] Increase the cluster-node-timeout to have longer delay between failover of each shard#2793
Merged
Merged
Conversation
enjoy-binbin
reviewed
Nov 2, 2025
enjoy-binbin
left a comment
Member
There was a problem hiding this comment.
thanks for the explanation, i will take a look next week.
sarthakaggarwal97
approved these changes
Nov 3, 2025
Contributor
There was a problem hiding this comment.
Thank you @hpatro. The explanation makes sense.
Contributor
|
The test failed again yesterday: https://github.com/valkey-io/valkey/actions/runs/19053371057/job/54418411594#step:6:9144 |
enjoy-binbin
approved these changes
Nov 5, 2025
Contributor
|
@hpatro I am seeing this flaky test in 8.0 and 8.1 as well. I can help backport once this PR is merged |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2793 +/- ##
============================================
+ Coverage 72.30% 72.40% +0.10%
============================================
Files 128 128
Lines 70211 70270 +59
============================================
+ Hits 50763 50877 +114
+ Misses 19448 19393 -55 🚀 New features to boost your workflow:
|
…er of each shard Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>
Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>
Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>
eff0a21 to
d448ddd
Compare
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 15, 2025
…delay between failover of each shard (valkey-io#2793)
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 15, 2025
…delay between failover of each shard (valkey-io#2793)
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 28, 2025
…delay between failover of each shard (valkey-io#2793)
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 28, 2025
…delay between failover of each shard (valkey-io#2793)
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 28, 2025
…delay between failover of each shard (valkey-io#2793)
zuiderkwast
pushed a commit
to zuiderkwast/valkey
that referenced
this pull request
Dec 3, 2025
…delay between failover of each shard (valkey-io#2793)
zuiderkwast
pushed a commit
that referenced
this pull request
Dec 4, 2025
…delay between failover of each shard (#2793)
zuiderkwast
pushed a commit
to zuiderkwast/valkey
that referenced
this pull request
Dec 4, 2025
…delay between failover of each shard (valkey-io#2793)
zuiderkwast
pushed a commit
that referenced
this pull request
Dec 9, 2025
…delay between failover of each shard (#2793)
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Jan 29, 2026
…delay between failover of each shard (valkey-io#2793)
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Jan 29, 2026
…delay between failover of each shard (valkey-io#2793) Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Jan 30, 2026
…delay between failover of each shard (valkey-io#2793) Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Jan 30, 2026
…delay between failover of each shard (valkey-io#2793) Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 4, 2026
…delay between failover of each shard (valkey-io#2793) Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 18, 2026
…delay between failover of each shard (valkey-io#2793) Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 20, 2026
…delay between failover of each shard (valkey-io#2793) Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
madolson
pushed a commit
that referenced
this pull request
Feb 24, 2026
…delay between failover of each shard (#2793) Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
hpatro
added a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
…delay between failover of each shard (valkey-io#2793) Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
hpatro
pushed a commit
that referenced
this pull request
Jun 10, 2026
…er of each shard (#3946) We previously attempted to set `cluster-node-timeout` to 15000 in #2793 but failed. This was because we did not explicitly specify it and relied on the default value, but `start_cluster` internally sets it to 3000. Closes #3932. Signed-off-by: Binbin <binloveplay1314@qq.com>
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Jun 22, 2026
…er of each shard (valkey-io#3946) We previously attempted to set `cluster-node-timeout` to 15000 in valkey-io#2793 but failed. This was because we did not explicitly specify it and relied on the default value, but `start_cluster` internally sets it to 3000. Closes valkey-io#3932. Signed-off-by: Binbin <binloveplay1314@qq.com> (cherry picked from commit f769037)
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Jun 22, 2026
…er of each shard (valkey-io#3946) (#314) We previously attempted to set `cluster-node-timeout` to 15000 in valkey-io#2793 but failed. This was because we did not explicitly specify it and relied on the default value, but `start_cluster` internally sets it to 3000. Closes valkey-io#3932. Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Jun 23, 2026
…er of each shard (valkey-io#3946) (#319) We previously attempted to set `cluster-node-timeout` to 15000 in valkey-io#2793 but failed. This was because we did not explicitly specify it and relied on the default value, but `start_cluster` internally sets it to 3000. Closes valkey-io#3932. Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Jun 23, 2026
…er of each shard (valkey-io#3946) (#323) We previously attempted to set `cluster-node-timeout` to 15000 in valkey-io#2793 but failed. This was because we did not explicitly specify it and relied on the default value, but `start_cluster` internally sets it to 3000. Closes valkey-io#3932. Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Jun 23, 2026
…er of each shard (valkey-io#3946) (#327) We previously attempted to set `cluster-node-timeout` to 15000 in valkey-io#2793 but failed. This was because we did not explicitly specify it and relied on the default value, but `start_cluster` internally sets it to 3000. Closes valkey-io#3932. Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Jun 23, 2026
…er of each shard (valkey-io#3946) We previously attempted to set `cluster-node-timeout` to 15000 in valkey-io#2793 but failed. This was because we did not explicitly specify it and relied on the default value, but `start_cluster` internally sets it to 3000. Closes valkey-io#3932. Signed-off-by: Binbin <binloveplay1314@qq.com>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Jun 23, 2026
…er of each shard (valkey-io#3946) (#334) We previously attempted to set `cluster-node-timeout` to 15000 in valkey-io#2793 but failed. This was because we did not explicitly specify it and relied on the default value, but `start_cluster` internally sets it to 3000. Closes valkey-io#3932. Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Jun 23, 2026
…er of each shard (valkey-io#3946) (#338) We previously attempted to set `cluster-node-timeout` to 15000 in valkey-io#2793 but failed. This was because we did not explicitly specify it and relied on the default value, but `start_cluster` internally sets it to 3000. Closes valkey-io#3932. Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Jun 23, 2026
…er of each shard (valkey-io#3946) (#343) We previously attempted to set `cluster-node-timeout` to 15000 in valkey-io#2793 but failed. This was because we did not explicitly specify it and relied on the default value, but `start_cluster` internally sets it to 3000. Closes valkey-io#3932. Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
valkeyrie-ops Bot
pushed a commit
that referenced
this pull request
Jul 3, 2026
…er of each shard (#3946) We previously attempted to set `cluster-node-timeout` to 15000 in #2793 but failed. This was because we did not explicitly specify it and relied on the default value, but `start_cluster` internally sets it to 3000. Closes #3932. Signed-off-by: Binbin <binloveplay1314@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2699
Removing the cluster-node-timeout override to allow more delay between a shard failover operation and avoid collision.
More explanation: #2699 (comment)