Fix outdated comment around clusterLink->flags#2752
Merged
Conversation
This clusterLink->flags was added in valkey-io#2310, during the review, we at the end chose to add a new CLUSTER_LINK_XXX flag instead of sharing the old CLUSTER_NODE_XXX flag. Signed-off-by: Binbin <binloveplay1314@qq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2752 +/- ##
============================================
- Coverage 72.64% 72.49% -0.15%
============================================
Files 128 128
Lines 71300 71300
============================================
- Hits 51794 51691 -103
- Misses 19506 19609 +103 🚀 New features to boost your workflow:
|
zuiderkwast
approved these changes
Oct 20, 2025
diego-ciciani01
pushed a commit
to diego-ciciani01/valkey
that referenced
this pull request
Oct 21, 2025
This clusterLink->flags was added in valkey-io#2310, during the review, we at the end chose to add a new CLUSTER_LINK_XXX flag instead of sharing the old CLUSTER_NODE_XXX flag. Signed-off-by: Binbin <binloveplay1314@qq.com>
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 15, 2025
This clusterLink->flags was added in valkey-io#2310, during the review, we at the end chose to add a new CLUSTER_LINK_XXX flag instead of sharing the old CLUSTER_NODE_XXX flag. Signed-off-by: Binbin <binloveplay1314@qq.com>
zhijun42
pushed a commit
to zhijun42/valkey
that referenced
this pull request
Nov 15, 2025
This clusterLink->flags was added in valkey-io#2310, during the review, we at the end chose to add a new CLUSTER_LINK_XXX flag instead of sharing the old CLUSTER_NODE_XXX flag. Signed-off-by: Binbin <binloveplay1314@qq.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
This clusterLink->flags was added in valkey-io#2310, during the review, we at the end chose to add a new CLUSTER_LINK_XXX flag instead of sharing the old CLUSTER_NODE_XXX flag. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This clusterLink->flags was added in #2310, during the review, we at
the end chose to add a new CLUSTER_LINK_XXX flag instead of sharing the
old CLUSTER_NODE_XXX flag.