Add sharded-pubsub tcl test to test_helper all test set#267
Merged
Conversation
Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>
Member
@hpatro Can you create an issue for this? Also attach the help wanted tag. |
madolson
approved these changes
Apr 9, 2024
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
Add sharded-pubsub to the supported TCL tests. Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe we could support listing all files via glob/regex pattern and we could just pass unit/* and avoid this issue. Adding the test to the
all_testsset manually for now.