Don't allow slot migration to myself node#2497
Merged
Merged
Conversation
This may result in meaningless slot migration job, we should return an error to user in advance to avoid operation error. Was introduced in valkey-io#1949. Signed-off-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: Binbin <binloveplay1314@qq.com>
enjoy-binbin
commented
Aug 17, 2025
zuiderkwast
reviewed
Aug 17, 2025
Signed-off-by: Binbin <binloveplay1314@qq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2497 +/- ##
============================================
+ Coverage 72.01% 72.05% +0.04%
============================================
Files 126 126
Lines 70448 70482 +34
============================================
+ Hits 50734 50787 +53
+ Misses 19714 19695 -19
🚀 New features to boost your workflow:
|
zuiderkwast
reviewed
Aug 18, 2025
madolson
reviewed
Aug 18, 2025
hpatro
approved these changes
Aug 18, 2025
Signed-off-by: Binbin <binloveplay1314@qq.com>
madolson
approved these changes
Aug 19, 2025
rjd15372
pushed a commit
to rjd15372/valkey
that referenced
this pull request
Sep 19, 2025
This may result in meaningless slot migration job, we should return an error to user in advance to avoid operation error. Also `by myself` is not correct English grammar and `myself` is a internal code terminology, changed to `by this node`. Was introduced in valkey-io#1949. --------- Signed-off-by: Binbin <binloveplay1314@qq.com>
rjd15372
pushed a commit
that referenced
this pull request
Sep 23, 2025
This may result in meaningless slot migration job, we should return an error to user in advance to avoid operation error. Also `by myself` is not correct English grammar and `myself` is a internal code terminology, changed to `by this node`. Was introduced in #1949. --------- Signed-off-by: Binbin <binloveplay1314@qq.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Oct 3, 2025
This may result in meaningless slot migration job, we should return an error to user in advance to avoid operation error. Also `by myself` is not correct English grammar and `myself` is a internal code terminology, changed to `by this node`. Was introduced in valkey-io#1949. --------- Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may result in meaningless slot migration job, we should
return an error to user in advance to avoid operation error.
Also
by myselfis not correct English grammar andmyselfis a internal code terminology, changed to
by this node.Was introduced in #1949.