Skip to content

Update swapdb command comment to mention why cluster mode is not allowed#2391

Merged
enjoy-binbin merged 1 commit into
valkey-io:unstablefrom
enjoy-binbin:update_swapdb
Aug 5, 2025
Merged

Update swapdb command comment to mention why cluster mode is not allowed#2391
enjoy-binbin merged 1 commit into
valkey-io:unstablefrom
enjoy-binbin:update_swapdb

Conversation

@enjoy-binbin

Copy link
Copy Markdown
Member

The comment has been outdated since #1671, update it.

The comment has been outdated since valkey-io#1671, update it.

Signed-off-by: Binbin <binloveplay1314@qq.com>
@codecov

codecov Bot commented Jul 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.46%. Comparing base (a481fe2) to head (b62901e).
⚠️ Report is 15 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2391      +/-   ##
============================================
+ Coverage     71.44%   71.46%   +0.02%     
============================================
  Files           123      123              
  Lines         67177    67177              
============================================
+ Hits          47992    48006      +14     
+ Misses        19185    19171      -14     
Files with missing lines Coverage Δ
src/db.c 90.00% <ø> (ø)

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvkashapov dvkashapov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enjoy-binbin enjoy-binbin merged commit a50690f into valkey-io:unstable Aug 5, 2025
52 checks passed
@enjoy-binbin enjoy-binbin deleted the update_swapdb branch August 5, 2025 03:47
allenss-amazon pushed a commit to allenss-amazon/valkey-core that referenced this pull request Aug 19, 2025
…wed (valkey-io#2391)

The comment has been outdated since valkey-io#1671, update it.

Signed-off-by: Binbin <binloveplay1314@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants