Remove trademarked language in code comments#223
Merged
Conversation
22d4b81 to
380e17b
Compare
zuiderkwast
requested changes
Apr 5, 2024
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
Partial review. I made it to the middle of module.c so far.
e1e1bec to
d825ce2
Compare
zuiderkwast
reviewed
Apr 6, 2024
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
I went through all of it now. Thanks for this massive work!
I'm sorry you got merge conflicts now, probably a lot of them. I hope they're easy to solve though.
zuiderkwast
reviewed
Apr 6, 2024
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
59d4fee to
0596f0b
Compare
Contributor
Author
|
Thanks for the thorough review! Merge conflicts weren't too bad |
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Signed-off-by: Jacob Murphy <jkmurphy@google.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Jacob Murphy <jkmurphy@google.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
22768c3 to
366ea33
Compare
Contributor
|
Please check the failed CI jobs. It seems some merge conflicts were not solved in the right way... |
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Contributor
Author
|
Yeah building is important... :) Had a comment that got double terminated after the merge. |
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Contributor
Author
|
Resolved some more merge conflicts |
zuiderkwast
approved these changes
Apr 9, 2024
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
Really awesome. I'll try to merge this fast before any other changes to avoid more merge conflict.
Signed-off-by: Viktor Söderqvist
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
This includes comments used for module API documentation.
* Strategy for replacement: Regex search: `(//|/\*| \*|#).* ("|\()?(r|R)edis( |\.
|'|\n|,|-|\)|")(?!nor the names of its contributors)(?!Ltd.)(?!Labs)(?!Contributors.)`
* Don't edit copyright comments
* Replace "Redis version X.X" -> "Redis OSS version X.X" to distinguish
from newly licensed repository
* Replace "Redis Object" -> "Object"
* Exclude markdown for now
* Don't edit Lua scripting comments referring to redis.X API
* Replace "Redis Protocol" -> "RESP"
* Replace redis-benchmark, -cli, -server, -check-aof/rdb with "valkey-"
prefix
* Most other places, I use best judgement to either remove "Redis", or
replace with "the server" or "server"
Fixes valkey-io#148
---------
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strategy for replacement:
(//|/\*| \*|#).* ("|\()?(r|R)edis( |\. |'|\n|,|-|\)|")(?!nor the names of its contributors)(?!Ltd.)(?!Labs)(?!Contributors.)Fixes #148