Remove deny_blocking check in moduleBlockClient, cleanup code and doc#2215
Merged
Conversation
This flag.deny_blocking check causes some code to becomde dead code. Some of the code below checks islua or ismulti, but they are marked with flag.deny_blocking and will return early. In addition, cleanup some documents, some of them are inaccurate, and restore the code of blocking_auth_cb in tests/modules/auth.c, this reply should be returned from core. The reply used to from the core and was changed to from the module in valkey-io#1819, and now it is from the core again. Cleanup some dead code around valkey-io#1819. Signed-off-by: Binbin <binloveplay1314@qq.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #2215 +/- ##
============================================
- Coverage 72.21% 72.21% -0.01%
============================================
Files 126 126
Lines 70635 70636 +1
============================================
- Hits 51012 51007 -5
- Misses 19623 19629 +6
🚀 New features to boost your workflow:
|
Member
Author
|
@zuiderkwast do you want to review this? You have reviewed the related PR and i have left some comment there. I seem to have forgotten why i was looking this issue, but i can recall there was something odd about it. |
zuiderkwast
reviewed
Aug 5, 2025
rjd15372
reviewed
Aug 25, 2025
Signed-off-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: Binbin <binloveplay1314@qq.com>
rjd15372
approved these changes
Aug 29, 2025
rjd15372
left a comment
Member
There was a problem hiding this comment.
I'm approving the PR but please add the assert that I mentioned in the code before merging the PR.
Signed-off-by: Binbin <binloveplay1314@qq.com>
rjd15372
pushed a commit
to rjd15372/valkey
that referenced
this pull request
Sep 19, 2025
…valkey-io#2215) This flag.deny_blocking check causes some code to becomde dead code. Some of the code below checks islua or ismulti, but they are marked with flag.deny_blocking and will return early. In addition, cleanup some documents, some of them are inaccurate, and restore the code of blocking_auth_cb in tests/modules/auth.c, this reply should be returned from core. The reply used to from the core and was changed to from the module in valkey-io#1819, and now it is from the core again. Cleanup some dead code around valkey-io#1819. Signed-off-by: Binbin <binloveplay1314@qq.com>
rjd15372
pushed a commit
that referenced
this pull request
Sep 23, 2025
…#2215) This flag.deny_blocking check causes some code to becomde dead code. Some of the code below checks islua or ismulti, but they are marked with flag.deny_blocking and will return early. In addition, cleanup some documents, some of them are inaccurate, and restore the code of blocking_auth_cb in tests/modules/auth.c, this reply should be returned from core. The reply used to from the core and was changed to from the module in #1819, and now it is from the core again. Cleanup some dead code around #1819. Signed-off-by: Binbin <binloveplay1314@qq.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Oct 3, 2025
…valkey-io#2215) This flag.deny_blocking check causes some code to becomde dead code. Some of the code below checks islua or ismulti, but they are marked with flag.deny_blocking and will return early. In addition, cleanup some documents, some of them are inaccurate, and restore the code of blocking_auth_cb in tests/modules/auth.c, this reply should be returned from core. The reply used to from the core and was changed to from the module in valkey-io#1819, and now it is from the core again. Cleanup some dead code around valkey-io#1819. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag.deny_blocking check causes some code to becomde dead code.
Some of the code below checks islua or ismulti, but they are marked
with flag.deny_blocking and will return early.
In addition, cleanup some documents, some of them are inaccurate,
and restore the code of blocking_auth_cb in tests/modules/auth.c,
this reply should be returned from core. The reply used to from the
core and was changed to from the module in #1819, and now it is from
the core again.
Cleanup some dead code around #1819.