Update tests to catch module context leaks if using aux save/load #2150
Merged
Conversation
5f954d2 to
bae466e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #2150 +/- ##
============================================
+ Coverage 71.26% 71.36% +0.09%
============================================
Files 122 122
Lines 66179 66179
============================================
+ Hits 47163 47229 +66
+ Misses 19016 18950 -66 🚀 New features to boost your workflow:
|
enjoy-binbin
approved these changes
May 29, 2025
zuiderkwast
reviewed
May 29, 2025
bae466e to
778b4b7
Compare
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
778b4b7 to
68eb047
Compare
chzhoo
pushed a commit
to chzhoo/valkey
that referenced
this pull request
Jun 12, 2025
…lkey-io#2150) See valkey-io#2132 for the fix. This just ensures that we always create context in all branches of aux_load and aux_save Signed-off-by: Jacob Murphy <jkmurphy@google.com> Signed-off-by: chzhoo <czawyx@163.com>
shanwan1
pushed a commit
to shanwan1/valkey
that referenced
this pull request
Jun 13, 2025
…lkey-io#2150) See valkey-io#2132 for the fix. This just ensures that we always create context in all branches of aux_load and aux_save Signed-off-by: Jacob Murphy <jkmurphy@google.com> Signed-off-by: shanwan1 <shanwan1@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2132 for the fix.
This just ensures that we always create context in all branches of aux_load and aux_save