Reverting the panic() introduced in #2027#2081
Merged
Merged
Conversation
There is existing code that depends on the previous behaviour. See valkey-io#2027. Signed-off-by: Stefan Mueller <muelstef@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #2081 +/- ##
===========================================
Coverage ? 71.09%
===========================================
Files ? 122
Lines ? 66021
Branches ? 0
===========================================
Hits ? 46937
Misses ? 19084
Partials ? 0
🚀 New features to boost your workflow:
|
madolson
approved these changes
May 13, 2025
shanwan1
pushed a commit
to shanwan1/valkey
that referenced
this pull request
Jun 13, 2025
Removing the `panic()` statement introduced previously. There is existing code that depends on the previous behaviour. See valkey-io#2027. Signed-off-by: Stefan Mueller <muelstef@amazon.com> Signed-off-by: shanwan1 <shanwan1@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the
panic()statement introduced previously.There is existing code that depends on the previous behaviour.
See #2027.