Use the correct port for migration#2050
Merged
Merged
Conversation
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #2050 +/- ##
============================================
- Coverage 71.05% 71.02% -0.03%
============================================
Files 123 123
Lines 66173 66173
============================================
- Hits 47017 47001 -16
- Misses 19156 19172 +16 🚀 New features to boost your workflow:
|
zuiderkwast
approved these changes
May 6, 2025
Member
|
lgtm |
rainsupreme
pushed a commit
to rainsupreme/valkey
that referenced
this pull request
May 14, 2025
One of the new tests that was added uses `CONFIG GET PORT`, which isn't right one for TLS. Also removed some other use of the helper which aren't actually used. Introduced as part of valkey-io#1671. --------- Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the new tests that was added uses
CONFIG GET PORT, which isn't right one for TLS.Also removed some other use of the helper which aren't actually used.