Properly escape double quotes and backslash in sdscatrepr#2036
Merged
Conversation
Signed-off-by: Fusl <fusl@meo.ws>
Signed-off-by: Fusl <fusl@meo.ws>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #2036 +/- ##
============================================
- Coverage 70.96% 70.94% -0.03%
============================================
Files 123 123
Lines 66135 66133 -2
============================================
- Hits 46934 46917 -17
- Misses 19201 19216 +15
🚀 New features to boost your workflow:
|
Signed-off-by: Fusl <fusl@meo.ws>
zuiderkwast
approved these changes
May 1, 2025
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
@madolson FYI. Apparently you reviewed the PR where the bug was introduced.
madolson
reviewed
May 2, 2025
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
madolson
approved these changes
May 2, 2025
Member
|
We did have some unit tests for |
mkmkme
pushed a commit
to valkey-io/valkey-py
that referenced
this pull request
May 5, 2025
Some of MONITOR tests got broken due to a bug in the server: valkey-io/valkey#2036 This commit disables those tests for these versions of Valkey server thus letting the CI proceed. Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
5 tasks
mkmkme
pushed a commit
to valkey-io/valkey-py
that referenced
this pull request
May 5, 2025
Some of MONITOR tests got broken due to a bug in the server: valkey-io/valkey#2036 This commit disables those tests for these versions of Valkey server thus letting the CI proceed. Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
rainsupreme
pushed a commit
to rainsupreme/valkey
that referenced
this pull request
May 14, 2025
…2036) Fixes valkey-io#2035, a bug introduced in valkey-io#1342 --------- Signed-off-by: Fusl <fusl@meo.ws> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Jun 4, 2025
…2036) Fixes valkey-io#2035, a bug introduced in valkey-io#1342 --------- Signed-off-by: Fusl <fusl@meo.ws> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Jun 4, 2025
…2036) Fixes valkey-io#2035, a bug introduced in valkey-io#1342 --------- Signed-off-by: Fusl <fusl@meo.ws> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2035, a bug introduced in #1342