Stabilize dual replication test to avoid getting LOADING error#1979
Merged
Conversation
Signed-off-by: artikell <739609084@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1979 +/- ##
============================================
+ Coverage 70.98% 71.04% +0.05%
============================================
Files 123 123
Lines 66033 66033
============================================
+ Hits 46875 46913 +38
+ Misses 19158 19120 -38 🚀 New features to boost your workflow:
|
nitaicaro
pushed a commit
to nitaicaro/valkey
that referenced
this pull request
Apr 22, 2025
…y-io#1979) Supplement the repair of valkey-io#1288, need to wait for the Loading to complete before executing `$replica replicaof no one`. Signed-off-by: artikell <739609084@qq.com> Signed-off-by: Nitai Caro <caronita@amazon.com>
nitaicaro
pushed a commit
to nitaicaro/valkey
that referenced
this pull request
Apr 22, 2025
…y-io#1979) Supplement the repair of valkey-io#1288, need to wait for the Loading to complete before executing `$replica replicaof no one`. Signed-off-by: artikell <739609084@qq.com>
nitaicaro
pushed a commit
to nitaicaro/valkey
that referenced
this pull request
Apr 22, 2025
…y-io#1979) Supplement the repair of valkey-io#1288, need to wait for the Loading to complete before executing `$replica replicaof no one`. Signed-off-by: artikell <739609084@qq.com>
hwware
pushed a commit
to wuranxx/valkey
that referenced
this pull request
Apr 24, 2025
…y-io#1979) Supplement the repair of valkey-io#1288, need to wait for the Loading to complete before executing `$replica replicaof no one`. Signed-off-by: artikell <739609084@qq.com> Signed-off-by: hwware <wen.hui.ware@gmail.com>
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 29, 2026
…y-io#1979) Supplement the repair of valkey-io#1288, need to wait for the Loading to complete before executing `$replica replicaof no one`. Signed-off-by: artikell <739609084@qq.com> (cherry picked from commit 0b94ca6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplement the repair of 1288, need to wait for the Loading to complete before executing
$replica replicaof no one.