Rename #include guards.#167
Merged
Merged
Conversation
Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com>
hwware
reviewed
Apr 3, 2024
hwware
left a comment
Contributor
There was a problem hiding this comment.
LGTM, only one minor issue, Thanks
| @@ -2,8 +2,8 @@ | |||
| * It contains alternative structs which omit the parts of the commands table | |||
| * that are not suitable for redis-cli, e.g. the command proc. */ | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * that are not suitable for redis-cli, e.g. the command proc. */ | |
| * that are not suitable for valkey-cli, e.g. the command proc. */ |
Contributor
There was a problem hiding this comment.
@hwware Let's leave it for another PR and we change only one thing in each PR. It is faster and more clear.
zuiderkwast
approved these changes
Apr 3, 2024
| @@ -2,8 +2,8 @@ | |||
| * It contains alternative structs which omit the parts of the commands table | |||
| * that are not suitable for redis-cli, e.g. the command proc. */ | |||
Contributor
There was a problem hiding this comment.
@hwware Let's leave it for another PR and we change only one thing in each PR. It is faster and more clear.
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Contributor
|
Suggestion for the future: Include "Fixes #xxx" in the description, where xxx is the issue number. It makes the PR linked to the issue and the issue will be closed automatically when the PR is merged. |
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
Rename include guard macros (redis -> valkey) and remove the leading double underscore. --------- Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com> Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename macro guard and remove the leading double underscore.
Fixes #137