Add availability_zone to the HELLO command history#1524
Merged
Conversation
madolson
approved these changes
Jan 7, 2025
madolson
left a comment
Member
There was a problem hiding this comment.
Oops, good followup. We should find a way to add some type of failure on the history, since I know we miss this periodically.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1524 +/- ##
============================================
- Coverage 70.85% 70.85% -0.01%
============================================
Files 120 120
Lines 64917 64956 +39
============================================
+ Hits 46000 46024 +24
- Misses 18917 18932 +15
|
Member
|
@rueian You also need to run |
Signed-off-by: Rueian <rueiancsie@gmail.com>
Contributor
Author
Oh, thanks for reminding me about that! I have updated the commands.def file. |
enjoy-binbin
approved these changes
Jan 8, 2025
enjoy-binbin
reviewed
Jan 8, 2025
config name should be availability-zone Signed-off-by: Binbin <binloveplay1314@qq.com>
Contributor
Author
|
Thank you @enjoy-binbin for the correction! |
kronwerk
pushed a commit
to kronwerk/valkey
that referenced
this pull request
Jan 27, 2025
This PR is a followup for valkey-io#1487. Signed-off-by: Rueian <rueiancsie@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for #1487.