Fix: restore replica output bytes stat update#1486
Merged
enjoy-binbin merged 2 commits intoDec 25, 2024
Conversation
Signed-off-by: Uri Yagelnik <uriy@amazon.com>
enjoy-binbin
approved these changes
Dec 24, 2024
Co-authored-by: Binbin <binloveplay1314@qq.com> Signed-off-by: uriyage <78144248+uriyage@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1486 +/- ##
============================================
- Coverage 70.86% 70.82% -0.05%
============================================
Files 119 119
Lines 64859 64860 +1
============================================
- Hits 45963 45934 -29
- Misses 18896 18926 +30
|
madolson
pushed a commit
to madolson/valkey
that referenced
this pull request
Jan 6, 2025
This PR fixes the missing stat update for `total_net_repl_output_bytes` that was removed during the refactoring in PR valkey-io#758. The metric was not being updated when writing to replica connections. Changes: - Restored the stat update in postWriteToClient for replica connections - Added integration test to verify the metric is properly updated Signed-off-by: Uri Yagelnik <uriy@amazon.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
madolson
pushed a commit
to madolson/valkey
that referenced
this pull request
Jan 7, 2025
This PR fixes the missing stat update for `total_net_repl_output_bytes` that was removed during the refactoring in PR valkey-io#758. The metric was not being updated when writing to replica connections. Changes: - Restored the stat update in postWriteToClient for replica connections - Added integration test to verify the metric is properly updated Signed-off-by: Uri Yagelnik <uriy@amazon.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
madolson
pushed a commit
that referenced
this pull request
Jan 7, 2025
This PR fixes the missing stat update for `total_net_repl_output_bytes` that was removed during the refactoring in PR #758. The metric was not being updated when writing to replica connections. Changes: - Restored the stat update in postWriteToClient for replica connections - Added integration test to verify the metric is properly updated Signed-off-by: Uri Yagelnik <uriy@amazon.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
kronwerk
pushed a commit
to kronwerk/valkey
that referenced
this pull request
Jan 27, 2025
This PR fixes the missing stat update for `total_net_repl_output_bytes` that was removed during the refactoring in PR valkey-io#758. The metric was not being updated when writing to replica connections. Changes: - Restored the stat update in postWriteToClient for replica connections - Added integration test to verify the metric is properly updated Signed-off-by: Uri Yagelnik <uriy@amazon.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the missing stat update for
total_net_repl_output_bytesthat was removed during the refactoring in PR #758. The metric was not being updated when writing to replica connections.Changes: