Add new flag in CLIENT LIST for import-source client#1398
Merged
Conversation
…n import-mode is off Signed-off-by: lvyanqi.lyq <lvyanqi.lyq@alibaba-inc.com>
Signed-off-by: lvyanqi.lyq <lvyanqi.lyq@alibaba-inc.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1398 +/- ##
============================================
+ Coverage 70.82% 70.87% +0.04%
============================================
Files 118 118
Lines 63561 63592 +31
============================================
+ Hits 45020 45071 +51
+ Misses 18541 18521 -20
|
zuiderkwast
reviewed
Dec 6, 2024
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
Looks good in general. Thanks!
Contributor
It's a good idea, but let's move this idea to #668. |
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Signed-off-by: Yanqi Lv <lvyanqi.lyq@alibaba-inc.com>
Contributor
Author
Thanks for your review and suggestion. I like this idea 😄 |
3 tasks
zuiderkwast
approved these changes
Dec 9, 2024
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
@valkey-io/core-team please approve the interface changes mentioned in the top comment.
enjoy-binbin
approved these changes
Dec 9, 2024
Co-authored-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Yanqi Lv <lvyanqi.lyq@alibaba-inc.com>
soloestoy
approved these changes
Dec 10, 2024
madolson
approved these changes
Dec 10, 2024
Contributor
|
@lyq2333 Can you open a doc PR to add the flag here: https://github.com/valkey-io/valkey-doc/blob/main/commands/client-list.md |
Contributor
Author
OK, I will include it in the introduction of import mode. |
vudiep411
pushed a commit
to Autxmaton/valkey
that referenced
this pull request
Dec 15, 2024
- Add new flag "I" in `CLIENT LIST` for import-source client - Add `DEBUG_CONFIG` for import-mode - Allow import-source status to be turned off when import-mode is off Fixes valkey-io#1350 and valkey-io#1185 (comment). --------- Signed-off-by: lvyanqi.lyq <lvyanqi.lyq@alibaba-inc.com> Signed-off-by: Yanqi Lv <lvyanqi.lyq@alibaba-inc.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Co-authored-by: Binbin <binloveplay1314@qq.com>
zuiderkwast
added a commit
to valkey-io/valkey-doc
that referenced
this pull request
Jan 2, 2025
This PR is for valkey-io/valkey#1185 and valkey-io/valkey#1398. --------- Signed-off-by: lvyanqi.lyq <lvyanqi.lyq@alibaba-inc.com> Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1350 and #1185 (comment).
CLIENT LISTfor import-source clientDEBUG_CONFIGfor import-mode