defrag: use monotime in module interface#1388
Merged
hpatro merged 1 commit intovalkey-io:unstablefrom Dec 3, 2024
Merged
Conversation
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1388 +/- ##
============================================
+ Coverage 70.68% 70.86% +0.18%
============================================
Files 118 118
Lines 63550 63549 -1
============================================
+ Hits 44919 45036 +117
+ Misses 18631 18513 -118
|
hpatro
approved these changes
Dec 3, 2024
Contributor
|
The test failure seems unrelated. |
vudiep411
pushed a commit
to Autxmaton/valkey
that referenced
this pull request
Dec 15, 2024
The recent PR (valkey-io#1242) converted Active Defrag to use `monotime`. In that change, a conversion was performed to continue to use `ustime()` as part of the module interface. Since this time is only used internally, and never actually exposed to the module, we can convert this to use `monotime` directly. Signed-off-by: Jim Brunner <brunnerj@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent PR (#1242) converted Active Defrag to use
monotime. In that change, a conversion was performed to continue to useustime()as part of the module interface. Since this time is only used internally, and never actually exposed to the module, we can convert this to usemonotimedirectly.