rename: redisassert -> serverassert#138
Merged
Merged
Conversation
Signed-off-by: 0del <bany.y0599@gmail.com>
c794275 to
9361814
Compare
Contributor
|
Hi @0del! Can you merge (or rebase) to lastest unstable? The spellcheck CI job has been fixed. |
zuiderkwast
approved these changes
Apr 2, 2024
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thanks for a small and simple PR. :)
There is a comment about "redisassert.h" inside serverassert.c. Do you want to fix it too? (If you don't, I can merge without that change too.)
Contributor
|
I ignored the spellcheck problem, because I know it has been fixed on unstable so the build will pass after merging. |
Contributor
Author
|
i created a PR #142 |
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
Signed-off-by: 0del <bany.y0599@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #134