Split dual-channel COB overrun tests to separate servers#1374
Merged
enjoy-binbin merged 1 commit intoDec 1, 2024
Conversation
1. The test isn't waiting long enough for the output buffer to overrun. This problem is happening because an error from the previous test is bleeding into the current test's logs. The simplest fix would be to split these tests. 2. Increased replication timeout to ensure sync fails due to output buffer overrun before a timeout occurs. Solve valkey-io#1367 Signed-off-by: naglera <anagler123@gmail.com>
Contributor
Author
|
Notice from the master test logs, the client which reached COB limit is client 11 which was created in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1374 +/- ##
============================================
+ Coverage 70.59% 70.62% +0.02%
============================================
Files 117 117
Lines 63324 63324
============================================
+ Hits 44704 44722 +18
+ Misses 18620 18602 -18 |
xbasel
reviewed
Nov 28, 2024
xbasel
approved these changes
Nov 28, 2024
Member
|
is splitting the test really the only option? we can fetch the replica client ID and use it to search the log. I generally prefer we avoid spawning many servers if no real need |
zuiderkwast
approved these changes
Nov 28, 2024
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
Good job! This test case has been haunting us for a while.
To start many servers take some time, so it's good to avoid it to keep total test time shorter. But in this case maybe it's not a problem. I also agree that separating them is better for isolation of tests where we check for log messages.
@ranshid @xbasel Do you want to try to find other alternatives?
enjoy-binbin
approved these changes
Nov 30, 2024
Member
I also suffered this when dealing with #1297, i think split it is a good idea though it will increase the test time. |
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 27, 2026
) 1. The test isn't waiting long enough for the output buffer to overrun. This problem is happening because an error from the previous test is bleeding into the current test's logs. The simplest fix would be to split these tests. 2. Increased replication timeout to ensure sync fails due to output buffer overrun before a timeout occurs. Fixes valkey-io#1367 Signed-off-by: naglera <anagler123@gmail.com> (cherry picked from commit 7043ef0)
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 27, 2026
) 1. The test isn't waiting long enough for the output buffer to overrun. This problem is happening because an error from the previous test is bleeding into the current test's logs. The simplest fix would be to split these tests. 2. Increased replication timeout to ensure sync fails due to output buffer overrun before a timeout occurs. Fixes valkey-io#1367 Signed-off-by: naglera <anagler123@gmail.com> (cherry picked from commit 7043ef0) (cherry picked from commit c40dc4e)
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
May 3, 2026
) 1. The test isn't waiting long enough for the output buffer to overrun. This problem is happening because an error from the previous test is bleeding into the current test's logs. The simplest fix would be to split these tests. 2. Increased replication timeout to ensure sync fails due to output buffer overrun before a timeout occurs. Fixes valkey-io#1367 Signed-off-by: naglera <anagler123@gmail.com> (cherry picked from commit 7043ef0) (cherry picked from commit c40dc4e)
madolson
pushed a commit
that referenced
this pull request
May 6, 2026
1. The test isn't waiting long enough for the output buffer to overrun. This problem is happening because an error from the previous test is bleeding into the current test's logs. The simplest fix would be to split these tests. 2. Increased replication timeout to ensure sync fails due to output buffer overrun before a timeout occurs. Fixes #1367 Signed-off-by: naglera <anagler123@gmail.com> (cherry picked from commit 7043ef0) (cherry picked from commit c40dc4e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1367