Disable lazy free in defrag test to fix 32bit daily failure#1370
Merged
Conversation
Signed-off-by: Zvi Schneider <zvi.schneider22@gmail.com>
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1370 +/- ##
============================================
+ Coverage 70.59% 70.75% +0.15%
============================================
Files 117 117
Lines 63324 63324
============================================
+ Hits 44704 44803 +99
+ Misses 18620 18521 -99 |
Contributor
Author
|
failure has an open issue already #1367 |
Contributor
Author
|
tested in a different branch where i added the ubuntu 32bit to the ci - https://github.com/zvi-code/valkey-z/actions/runs/12065928410/job/33645715745 |
zuiderkwast
approved these changes
Nov 28, 2024
vitarb
pushed a commit
to vitarb/valkey
that referenced
this pull request
Jun 24, 2025
…o#1370) Signed-off-by: Zvi Schneider <zvi.schneider22@gmail.com> Co-authored-by: Zvi Schneider <zvi.schneider22@gmail.com>
vitarb
pushed a commit
to vitarb/valkey
that referenced
this pull request
Jun 24, 2025
…o#1370) Signed-off-by: Zvi Schneider <zvi.schneider22@gmail.com> Co-authored-by: Zvi Schneider <zvi.schneider22@gmail.com>
zuiderkwast
pushed a commit
to vitarb/valkey
that referenced
this pull request
Aug 15, 2025
…o#1370) Signed-off-by: Zvi Schneider <zvi.schneider22@gmail.com> Co-authored-by: Zvi Schneider <zvi.schneider22@gmail.com>
zuiderkwast
pushed a commit
to vitarb/valkey
that referenced
this pull request
Aug 15, 2025
…o#1370) Signed-off-by: Zvi Schneider <zvi.schneider22@gmail.com> Co-authored-by: Zvi Schneider <zvi.schneider22@gmail.com> Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
zuiderkwast
pushed a commit
to vitarb/valkey
that referenced
this pull request
Aug 21, 2025
…o#1370) Signed-off-by: Zvi Schneider <zvi.schneider22@gmail.com> Co-authored-by: Zvi Schneider <zvi.schneider22@gmail.com> Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
zuiderkwast
pushed a commit
that referenced
this pull request
Aug 22, 2025
Signed-off-by: Zvi Schneider <zvi.schneider22@gmail.com> Co-authored-by: Zvi Schneider <zvi.schneider22@gmail.com> Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Sep 16, 2025
…o#1370) Signed-off-by: Zvi Schneider <zvi.schneider22@gmail.com> Co-authored-by: Zvi Schneider <zvi.schneider22@gmail.com> Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disable lazy free in defrag test to fix #1344