Add io-threads-do-reads config to deprecated config table to have no effect.#1138
Merged
zuiderkwast merged 4 commits intoOct 10, 2024
Merged
Conversation
…effect on io-threads Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1138 +/- ##
===========================================
Coverage ? 70.59%
===========================================
Files ? 114
Lines ? 61716
Branches ? 0
===========================================
Hits ? 43567
Misses ? 18149
Partials ? 0
|
melroy89
reviewed
Oct 9, 2024
melroy89
left a comment
Contributor
There was a problem hiding this comment.
Again please update documentation and example config file explaining this option is deprecated and doesn't do anything anymore.
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Contributor
Author
|
Added a note in the valkey.conf file as it is deprecated and avoid using it in future. Thanks for remainding it. |
Contributor
|
Small typo in title: depricated -> deprecated |
zuiderkwast
approved these changes
Oct 10, 2024
zuiderkwast
reviewed
Oct 10, 2024
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
eifrah-aws
pushed a commit
to eifrah-aws/valkey
that referenced
this pull request
Oct 20, 2024
…effect. (valkey-io#1138) this fixes: valkey-io#1116 _Issue details from valkey-io#1116 by @zuiderkwast_ > This config is undocumented since valkey-io#758. The default was changed to "yes" and it is quite useless to set it to "no". Yet, it can happen that some user has an old config file where it is explicitly set to "no". The result will be bad performace, since I/O threads will not do all the I/O. > > It's indeed confusing. > > 1. Either remove the whole option from the code. And thus no need for documentation. _OR:_ > 2. Introduce the option back in the configuration, just as a comment is fine. And showing the default value "yes": `# io-threads-do-reads yes` with additional text. > > _Originally posted by @melroy89 in [valkey-io#1019 (reply in thread)](https://github.com/orgs/valkey-io/discussions/1019#discussioncomment-10824778)_ --------- Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes: #1116
Issue details from #1116 by @zuiderkwast