refactor: vCenter entity type constants#360
Merged
TylerGillson merged 1 commit intomainfrom Sep 6, 2024
Merged
Conversation
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
approved these changes
Sep 6, 2024
Member
ahmad-ibra
left a comment
There was a problem hiding this comment.
LGTM, just left a single question around one of the entity string values
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 37.56% 38.57% +1.00%
==========================================
Files 30 29 -1
Lines 1858 1737 -121
==========================================
- Hits 698 670 -28
+ Misses 1088 995 -93
Partials 72 72
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
TylerGillson
added a commit
that referenced
this pull request
Sep 10, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](v0.0.34...v0.1.0) (2024-09-10) ### ⚠ BREAKING CHANGES * support additional vCenter entities for privilege rules ([#362](#362)) * remove RolePrivilegeValidationRules, add enums to API, remove "cloud" refs and simplify account handling ([#357](#357)) ### Features * support additional vCenter entities for privilege rules ([#362](#362)) ([abe3a94](abe3a94)) ### Docs * fix typos ([f9b63d8](f9b63d8)) * update CR samples ([#367](#367)) ([e6968ba](e6968ba)) ### Dependency Updates * **deps:** update golang.org/x/exp digest to 701f63a ([#364](#364)) ([37af6b3](37af6b3)) * **deps:** update golang.org/x/exp digest to e7e105d ([#355](#355)) ([b67befa](b67befa)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.2 ([#353](#353)) ([f9eab82](f9eab82)) * **deps:** update module github.com/onsi/gomega to v1.34.2 ([#354](#354)) ([d834600](d834600)) * **deps:** update module github.com/validator-labs/validator to v0.1.10 ([#356](#356)) ([3c0c928](3c0c928)) * **deps:** update module github.com/validator-labs/validator to v0.1.9 ([#347](#347)) ([cd8ff75](cd8ff75)) * **deps:** update module sigs.k8s.io/cluster-api to v1.8.2 ([#358](#358)) ([0f7c799](0f7c799)) ### Refactoring * remove RolePrivilegeValidationRules, add enums to API, remove "cloud" refs and simplify account handling ([#357](#357)) ([4388804](4388804)) * rename CloudDriver -> VCenterDriver ([#361](#361)) ([8943ff6](8943ff6)) * vCenter entity type constants ([#360](#360)) ([3fb6f51](3fb6f51)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
Make all vCenter entity types constants.