Skip to content

Update ja-JP.json roundabout phrases#2474

Merged
danpaz merged 1 commit intomasterfrom
ja_roundabouts
Jul 16, 2020
Merged

Update ja-JP.json roundabout phrases#2474
danpaz merged 1 commit intomasterfrom
ja_roundabouts

Conversation

@danpaz
Copy link
Copy Markdown
Collaborator

@danpaz danpaz commented Jul 16, 2020

Issue

@tsuz continues to spot localization issues in Japanese 😄 . Thanks!

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@danpaz danpaz requested a review from mandeepsandhu July 16, 2020 14:32
@danpaz danpaz merged commit 3783b28 into master Jul 16, 2020
@danpaz danpaz deleted the ja_roundabouts branch July 16, 2020 18:11
yuzheyan added a commit that referenced this pull request Jul 28, 2020
@yuzheyan
Merge branch 'master' of github.com:valhalla/valhalla
8bb8068 
* 'master' of github.com:valhalla/valhalla:
  Fix segfault: Do not combine last turn channel maneuver (#2463)
  Update ja-JP.json roundabout phrases (#2474)
  Update ja-JP.json (#2471)
  Add Dutch locale (#2464)
  Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandeepsandhu mandeepsandhu mandeepsandhu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danpaz @mandeepsandhu