Accept only major version String in FrontendVersion CTOR#7815
Merged
Conversation
pleku
approved these changes
Mar 15, 2020
pleku
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
|
@denis-anisimov please handle the cherry picking. Also, this change had lots of totally unrelated whitespace changes which made it very annoying to review. We need to fix this somehow |
denis-anisimov
pushed a commit
that referenced
this pull request
Mar 16, 2020
denis-anisimov
pushed a commit
that referenced
this pull request
Mar 16, 2020
denis-anisimov
pushed a commit
that referenced
this pull request
Mar 16, 2020
Fixes #7800 # Conflicts: # flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendVersion.java # flow-server/src/test/java/com/vaadin/flow/server/frontend/FrontendVersionTest.java
pleku
pushed a commit
that referenced
this pull request
Mar 17, 2020
pleku
pushed a commit
that referenced
this pull request
Mar 17, 2020
pleku
pushed a commit
that referenced
this pull request
Mar 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7800
This change is