fix: Handle an extra spaces in class names properly#11861
Merged
Conversation
| throw new IllegalArgumentException( | ||
| "CSS class names cannot include an empty class name"); | ||
| } | ||
| String[] parts = rawClassName.split("\\s+"); |
There was a problem hiding this comment.
StringSplitter: String.split(String) has surprising behavior
(at-me in a reply with help or ignore)
caalador
requested changes
Sep 16, 2021
Contributor
caalador
left a comment
There was a problem hiding this comment.
2 added tests are broken.
caalador
approved these changes
Sep 16, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 17, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 17, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 17, 2021
vaadin-bot
added a commit
that referenced
this pull request
Sep 17, 2021
vaadin-bot
added a commit
that referenced
this pull request
Sep 17, 2021
vaadin-bot
added a commit
that referenced
this pull request
Sep 17, 2021
Collaborator
|
This ticket/PR has been released with platform 22.0.0.alpha4 and is also targeting the upcoming stable 22.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11709
Type of change
Checklist
Additional for
Featuretype of change