Skip to content

Conversation

@khalid586
Copy link

Typo has been fixed.

@Liedtke
Copy link
Member

Liedtke commented Oct 28, 2023

Please note that the Github repository is a mirror only.
For more information on how to contribute to v8: https://v8.dev/docs/contribute

@Liedtke Liedtke closed this Oct 28, 2023
hubot pushed a commit that referenced this pull request Jan 27, 2025
(cherry picked from commit 5c3b50c)

Fixed: 374627491
Change-Id: I7b6142b45295ba795a8ae8a90692fc09e704b65d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6032225
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#97274}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6048230
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Gyuyoung Kim (xWF) <qkim@google.com>
Cr-Commit-Position: refs/branch-heads/12.6@{#84}
Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2}
Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot pushed a commit that referenced this pull request May 1, 2025
(cherry picked from commit eb9b259)

Fixed: 398065918
Change-Id: Ifc163b6633e55ca707815ef910a26dfb144a667b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6297972
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Olivier Flückiger <olivf@chromium.org>
Auto-Submit: Olivier Flückiger <olivf@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#98917}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6475764
Reviewed-by: Olivier Flückiger <olivf@chromium.org>
Commit-Queue: Gyuyoung Kim (xWF) <qkim@google.com>
Cr-Commit-Position: refs/branch-heads/13.2@{#84}
Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1}
Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot pushed a commit that referenced this pull request Dec 10, 2025
M138 merge issues:

src/maglev/maglev-code-generator.cc:
  in MaglevCodeGeneratingNodeProcessor::Process():
  regalloc_info() doesn't exist in M138, called it directly using
  the node object:
-      DCHECK(!node->regalloc_info()->has_register());
+      DCHECK(!node->has_register());

The regalloc should clear the node allocations when it is done.
Failing to do so can cause the codegen to use stale register state.
In this concrete example the exception handler trampolines would not
load from the spill slot due to the left over allocation.

(cherry picked from commit 7ef5ae5)

Bug: 457351015
Change-Id: Ia113c0b3373b5b11250e11d66d63b6a67b63b13f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7119379
Auto-Submit: Olivier Flückiger <olivf@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#103535}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7176667
Reviewed-by: Olivier Flückiger <olivf@chromium.org>
Commit-Queue: Roger Felipe Zanoni da Silva (xWF) <rzanoni@google.com>
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/branch-heads/13.8@{#84}
Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1}
Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants