-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix field escape parsing error in csvparser #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fixes a bug in `CsvParser.prototype.escapeField` that improperly handles single-character escapes like `\\`, which affects parsing paths on DOS-based file systems. Originally found in thlorenz/v8-tools-core#1 and needed for thlorenz/deoptigate#13.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I42eff6358d63ffd305e2cb3847a806e2d5e82b72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2079250 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.1@{v8#36} Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1} Cr-Branched-From: f22c213-refs/heads/master@{#66031}
…'riscv-porting-dev' Resolve "test-run-machops/RunWord32ReverseBytes failed" Closes #36 See merge request swlab/swe/v8!46
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Id634d110c4ef8a195275dc9d4a0a89052bf9cd6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330271 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.5@{v8#36} Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1} Cr-Branched-From: dd58472-refs/heads/master@{#68510}
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: If41d4d43cef3a96a15ad813201b0d719610cc996 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869861 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.8@{v8#36} Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1} Cr-Branched-From: 2314928-refs/heads/master@{#63555}
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I43ac26800532f5b8542945280276fcf20a255a32 Reviewed-on: https://chromium-review.googlesource.com/c/1400182 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.2@{v8#36} Cr-Branched-From: 6acd03c-refs/heads/7.2.502@{#1} Cr-Branched-From: b03041d-refs/heads/master@{#57910}
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I56f9070ce9dfc4959b13144aca078182971132c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1548938 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.4@{v8#36} Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1} Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I08cd47ff58017002e2fe5bde538ae4070ea59469 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899252 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.9@{v8#36} Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1} Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ic89bc5bdbff216913eb0c07ae28f3d4a2286d345 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049874 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.0@{v8#36} Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2} Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}
Revision: 9439a1d NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=leszeks@chromium.org Bug: chromium:926651 Change-Id: I24da2ec5c87a7a1489a7d186fae69cc196ffe503 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503378 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/branch-heads/7.3@{v8#36} Cr-Branched-From: 9df9418-refs/heads/7.3.492@{v8#2} Cr-Branched-From: be213cf-refs/heads/master@{#59024}
Whenever left-trimming is possible (e.g. whenever user code is called), we must not store a reference to an exposed JSArray's elements. Original CL: https://crrev.com/c/1292066. No-Try: true No-Presubmit: true No-Treechecks: true Bug: chromium:897366,v8:7382 Change-Id: I98f698b659cf977461b2fc8be65533eff312c9ef Reviewed-on: https://chromium-review.googlesource.com/c/1319753 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/branch-heads/7.1@{v8#36} Cr-Branched-From: f70aaa8-refs/heads/7.1.302@{#1} Cr-Branched-From: 1dbcc78-refs/heads/master@{#56462}
Revision: 3591890 R=leszeks@chromium.org Tbr: leszeks@chromium.org No-Try: true No-Presubmit: true No-Treechecks: true Bug: chromium:974612 Change-Id: If780c2dac6bffca2ee00363f7af32b199bb0a703 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1684182 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/branch-heads/7.6@{v8#36} Cr-Branched-From: 2cb2573-refs/heads/7.6.303@{#1} Cr-Branched-From: 201c509-refs/heads/master@{#61902}
Revision: c9b48e9 BUG=chromium:940274 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I964b1e065c65708436274dee59c8e0b1f4f2eb0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622118 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{v8#36} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
This reverts commit 95c3209. Reason for revert: Build failure Original change's description: > Merged: [Torque] Array.prototype.shift correctness fix > > Revision: c9b48e9 > > BUG=chromium:940274 > LOG=N > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > > Change-Id: I964b1e065c65708436274dee59c8e0b1f4f2eb0f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622118 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/branch-heads/7.5@{v8#36} > Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} > Cr-Branched-From: 912b391-refs/heads/master@{#60911} TBR=mvstanton@chromium.org,tebbi@chromium.org Change-Id: I1944421829814f54f2cd9876199eb681f8520681 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:940274 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622966 Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/branch-heads/7.5@{v8#40} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
When filling stack slots, the start offset can be too large to fit into the immediate of a str instruction (which is used to handle remainders after stp). For example, a function with 32 i64 params will require 256 bytes reserved for the params, so the offset starts at 256 + 16 (instance) = 272. This does not fit into a int9, so we hit an UNREACHABLE case when emitting str. The fix here checks that start can fit in an unscaled immediate, and if it doesn't fallback to the general case. We could use the Str from macro-asesmbler, but that uses another instruction, so we are not saving anything. A check for IsImmLSUnscaled(-start-12) is sufficient because 12 is the largest possible value for remainder. So if -start-12 fits, everything else will fit. TBR=clemensb@chromium.org (cherry picked from commit c92e74f) Bug: v8:10645 Change-Id: I704a69e6b0c7b00a44e85b2c6e0d34767c9b34e4 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274090 Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/branch-heads/8.4@{v8#36} Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1} Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
…hing" This reverts commit d2ce574. Reason for revert: We reverted the early canonicalization change, so we need to worry about non-canonicalized shuffles now. Original change's description: > [wasm-simd][arm64] Update f32x4.mul(dup) pattern matching > > We now canonicalize earlier in the pipeline, and don't need to worry > about non-canonicalized shuffles. > > Bug: v8:11542,v8:11257 > Change-Id: If9f5c44061465be339c98e479fd8c5a437bbd74b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2778673 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73645} (cherry picked from commit 17e040c) Bug: v8:11542 Bug: v8:11257 Tbr: bbudge@chromium.org No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: Ib912d86cc94acbdf0480b7d52de480d98ce546bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2852517 Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/branch-heads/9.1@{v8#36} Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1} Cr-Branched-From: f565e72-refs/heads/master@{#73847}
This CL adds `can_use_compiled_module` parameter to WasmStreaming::Finish() that is used by Chromium https://chromium-review.googlesource.com/c/chromium/src/+/3282643 to invalidate compiled module bytes after SetCompiledModuleBytes(). (cherry picked from commit b0c6dd8) Bug: chromium:1260939 Change-Id: I28554ed79ed56349fa38517ed03785e0c8146b4d No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306788 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/branch-heads/9.6@{v8#36} Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1} Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I44359b3b90ef41cb07f82520869f507fe979e894 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3024444 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.2@{v8#36} Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1} Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: If036f0a0a0926606398ddb48265b46188c345830 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2682503 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.9@{v8#36} Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1} Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I7b29f81ba6d0e58aed56493b8dd9cad1b41826af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181874 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.4@{v8#36} Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1} Cr-Branched-From: 2890419-refs/heads/master@{#76233}
Change-Id: I0520d3b8fe1bb22f1cda8c89a272fff98234e1f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3755202 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.3@{v8#36} Cr-Branched-From: 1a8f4ca-refs/heads/10.3.174@{#1} Cr-Branched-From: 8fbefa4-refs/heads/main@{#80471}
(cherry picked from commit 14cc79c) Bug: chromium:1252634, chromium:1056170 Change-Id: Ifdecca29dbff4ed3d6ee2acd547a20add482d59f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183167 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#77087} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207888 Cr-Commit-Position: refs/branch-heads/9.5@{v8#36} Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1} Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
This reverts commit 815b12d. Reason for revert: breaks M86 branch build in component mode (https://ci.chromium.org/p/chromium-m86/builders/ci/Linux%20Builder%20%28dbg%29) Original change's description: > Merged: [runtime] Fix sorted order of DescriptorArray entries > > Revision: 518d67a > > BUG=chromium:1133527 > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > R=verwaest@chromium.org > > Change-Id: I10831b27c5c10b9a967e47a5fd08f806ef5d306d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502328 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/branch-heads/8.6@{v8#34} > Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} > Cr-Branched-From: a626bc0-refs/heads/master@{#69472} TBR=ishell@chromium.org,verwaest@chromium.org Change-Id: Icfaae7cc5af778165929fcd50aead433421728c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1133527 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504509 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/branch-heads/8.6@{v8#36} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
To make sure that Wasm memories don't exceed JSArrayBuffer size. This change shouldn't affect real-world modules, because finding enough contiguous address space to allocate that much memory is virtually impossible anyway. TBR=jkummerow@chromium.org (cherry picked from commit 6d7ed2e) Fixed: chromium:1242339 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: Ie6bf129c5b3501b7e256e4358a257d9c202fa78c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3338663 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/branch-heads/9.7@{v8#36} Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1} Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I88a372ccdb9ee93a914023c7e35102b7cf396f83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2520757 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.7@{v8#36} Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1} Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
Change-Id: Ifb6348446771fee7a9221f6d8b75d904997c0830 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3763001 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.4@{v8#36} Cr-Branched-From: b1413ed-refs/heads/10.4.132@{#1} Cr-Branched-From: 9d0a093-refs/heads/main@{#80972}
Change-Id: I5f77f5a6113931e9f0a404145666224dc378a60e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4293996 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.0@{v8#36} Cr-Branched-From: 06097c6-refs/heads/11.0.226@{#1} Cr-Branched-From: 6bf3344-refs/heads/main@{#84857}
Change-Id: Iefc95f3d651bd3fbadffa0d1f056bbe35409dea1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3986505 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.2@{v8#36} Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1} Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
Change-Id: Ic37dd1a4dd347d808360f9084d3e9736878e1702 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4455264 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.2@{v8#36} Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1} Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
Change-Id: Ib9dff77c50f591705fe92ea36bfb4a56f5d7cdaf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3941864 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.6@{v8#36} Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1} Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
R=jkummerow@chromium.org Bug: chromium:1377816 (cherry picked from commit f517e51) Change-Id: I5f073c88feb3736acfd04af4896908f5b49678a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3999133 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/branch-heads/10.7@{v8#36} Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1} Cr-Branched-From: 9521696-refs/heads/main@{#83201}
Change-Id: Iaba01ba03341b1559e39ca83a8ab2dcf0efb3633 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4579120 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.4@{v8#36} Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1} Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
Change-Id: I65216bdd10e664697c9c6ab3d311496e13974215 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4690951 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.5@{v8#36} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}
(cherry picked from commit f188422) Bug: chromium:1479104 Change-Id: Iddc16d8add4dc6bf6f55f537da44770bea6f4bc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4862980 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/branch-heads/11.6@{v8#36} Cr-Branched-From: e29c028-refs/heads/11.6.189@{v8#3} Cr-Branched-From: 95cbef2-refs/heads/main@{#88340}
…in AssembleMove Bug: v8:14334 (cherry picked from commit f233e69) Change-Id: I03e50b194939dd3317871bc8640e874ad21f28aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4884631 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/branch-heads/11.7@{v8#36} Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1} Cr-Branched-From: aeb4552-refs/heads/main@{#89415}
Change-Id: I774acf5aca875d0f3a961b50c3a1c48da8e44f3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5157274 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.1@{v8#36} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
Instead of always checking memory 0, do check if the actually cached memory is growable. R=jkummerow@chromium.org (cherry picked from commit 1285ee4) Bug: chromium:1518257 Change-Id: Ic415e281d85bb979f1fd27aa5e14a5fcc52ffbf1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5232161 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/branch-heads/12.0@{v8#36} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
This merge contains two CLs: CL1: [wasm] Add generic wasm-to-js wrapper for invalid signatures So far a specific wasm-to-js wrapper got compiled when a wrapper was requested for a signature that was not compatible with JS, e.g. a signature that contains a simd. This CL introduces a generic wrapper for invalid signatures that throws an exception unconditionally. There was a code path where the generic wrapper was used for invalid signatures. This code path now also uses the new wrapper for invalid signatures. CL2: [wasm] Fix no-generic-wrapper case in GetOrCreateWasmInternalFunction The existing code always used the generic wrapper, even when the generic wrapper was disabled. With this CL we use the generic wrapper only if it is enabled. R=thibaudm@chromium.org Bug: chromium:323694592 (cherry picked from commit eacf7f4) Change-Id: If10bf51fc5fd05c68b6c89affefcbe7d950b4ad7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5314416 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/branch-heads/12.2@{#36} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
Fixed: 339736513 (cherry picked from commit 8a69c78) Change-Id: If87462eb044c194798a32cb25a5f3648ff823196 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5555847 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/branch-heads/12.4@{#36} Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1} Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}
When we encode a JS value in a wasm exception, canonicalize the type stored in the tag's signature first. Canonicalize it using the tag's original module by storing the instance on the tag object. R=jkummerow@chromium.org Bug: 346197738 (cherry picked from commit 89dc6ea) Change-Id: I9a0b42702b1e5f7ef25091ed99c9bb00849bbc10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5633661 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/branch-heads/12.6@{#36} Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2} Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
This reverts commit 284b51f. Reason for revert: Crashes on 128 branch Original change's description: > Merged: [compiler] Ensure old SFIs stay alive for merging > > When merging two scripts, we decide whether to use new or old SFIs in > one pass over the script info list, and patch old SFIs (in bytecode > constant pools) with new ones in another pass. If there is a GC that > clears some of the weak script info list pointers between these two > passes, then various assumptions break, leading to SFIs in the published > result pointing at the wrong script. > > Make sure that any old SFIs that were encountered in the first pass stay > alive for the second pass. > > Bug: 355575275 > (cherry picked from commit b2b082c) > > Change-Id: Id15a6c6e67544bbaad561312ccf8a9816f8d98f2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5797603 > Reviewed-by: Patrick Thier <pthier@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/branch-heads/12.8@{#32} > Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} > Cr-Branched-From: 451b63e-refs/heads/main@{#95151} Bug: 355575275 Change-Id: Ib5f4473312dcc91a102dd7fc40e108904149ff8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5801505 Auto-Submit: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.8@{#36} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
This avoids having to load the value back into a register if it was spilled inside of the loop. R=jkummerow@chromium.org (cherry picked from commit 9797576) Fixed: chromium:360700873 Change-Id: I24f5deacebc893293e8a3c007e9f070c7fa0ccd2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5797073 Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#95711} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5804783 Auto-Submit: Roger Felipe Zanoni da Silva (xWF) <rzanoni@google.com> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/branch-heads/12.7@{#36} Cr-Branched-From: 35cc908-refs/heads/12.7.224@{#1} Cr-Branched-From: 6d60e67-refs/heads/main@{#94324}
Change-Id: I9867071168dbbeb781775b109e080ad8811878a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5859156 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.9@{#36} Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1} Cr-Branched-From: da4200b-refs/heads/main@{#95679}
Version incremented at https://cr-buildbucket.appspot.com/build/8733909967492941281 Change-Id: I4e25f83e5521ded91ae76366092e5b469d3f7d4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5936933 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.0@{#36} Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1} Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
Bug: chromium:379843860 (cherry picked from commit c9fd53d) Change-Id: I31b5ad3031c50c305e0a29c89366e72703d238d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6074946 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Auto-Submit: Darius Mercadier <dmercadier@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/branch-heads/13.2@{#36} Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1} Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
The Object.assign fastcase should not override the hash of the to object. Bug: 383647255 (cherry picked from commit 357d0dd) Change-Id: Icd6e9cb9a528dac7cd6aa2baae11ebc74bd4655d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6098273 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/branch-heads/13.1@{#36} Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1} Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}
Add missing check for page being marked. Fixed: 392521083 (cherry picked from commit ce071a2) Change-Id: I329cf0d24e7370a2c75047a98f07297b12c297fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6219155 Auto-Submit: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/branch-heads/13.3@{#36} Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1} Cr-Branched-From: 3348638-refs/heads/main@{#97937}
Version incremented at https://cr-buildbucket.appspot.com/build/8721068411042402097 Change-Id: I40fda1176ee8908c3de4c5f06ad12c50dd170f3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6334413 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.4@{#36} Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1} Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
Version incremented at https://cr-buildbucket.appspot.com/build/8711854324462793649 Change-Id: If8de10888d558778a17c37d7087cf9b2151d3e37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6648090 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.8@{#36} Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1} Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
(cherry picked from commit 22e9d96) Bug: 427663123 Change-Id: Iefdb15828d807bf9452b88e918a4b46cc2d422fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6678591 Commit-Queue: Stephen Röttger <sroettger@google.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#101050} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6677675 Reviewed-by: Stephen Röttger <sroettger@google.com> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/branch-heads/13.7@{#36} Cr-Branched-From: dd5370d-refs/heads/13.7.152@{#1} Cr-Branched-From: fa9b753-refs/heads/main@{#99927}
Read the code from the dispatch handle to avoid the dangerous double-fetch of the dispatch handle. R=olivf@chromium.org (cherry picked from commit c82024b) Bug: 430960844 Change-Id: Ibb37036fe61e28e77548f18b4419b3bfe6ca7fd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6811147 Auto-Submit: Clemens Backes <clemensb@chromium.org> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Commit-Queue: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/branch-heads/13.9@{#36} Cr-Branched-From: 76ea409-refs/heads/13.9.205@{#1} Cr-Branched-From: 2824212-refs/heads/main@{#100941}
Version incremented at https://cr-buildbucket.appspot.com/build/8698593194152132625 Change-Id: I514e02e2a28db14ec212586bbd8627beea7e9440 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7134128 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.2@{#36} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
…Pool" This reverts commit 30c0047. Reason for revert: b/462213735 Original change's description: > [arm64] Use CHECK (instead of DCHECK) in CheckVeennerPool > > This is a hardening measure to prevent potential data corruption > by crashing immediately if the invariant is ever violated in release > mode. > > Bug: 435640828 > Change-Id: Idc10542a68d52747aa1e8500ae3ef3a2cf138330 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7014092 > Auto-Submit: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Cr-Commit-Position: refs/heads/main@{#102961} Bug: 462213735 Fixed: 475265552 (cherry picked from commit ff77083) Change-Id: Ia915b92692f35c39defa297f1d12bd86f0ea89f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7457271 Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/branch-heads/14.4@{#36} Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1} Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
This fixes a bug in
CsvParser.prototype.escapeFieldthat improperly handles single-character escapes like\\, which affects parsing paths on DOS-based file systems.Originally found in thlorenz/v8-tools-core#1 and needed for thlorenz/deoptigate#13.