mirrored from https://chromium.googlesource.com/v8/v8.git
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
6.3 lkgr #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance and stability improvements on all platforms. TBR=v8-autoroll@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ie97ba96c54f0cc820ab9700b3318e6826cea5cc1 Reviewed-on: https://chromium-review.googlesource.com/710396 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
TBR=machenbach@chromium.org Change-Id: I323a4b4e27c3c623cd58aef8a7a13a5dcf135755 Reviewed-on: https://chromium-review.googlesource.com/716116 Reviewed-by: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#1} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I419977d23adf80a7ef57e8b3d17307847f48406f Reviewed-on: https://chromium-review.googlesource.com/715779 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#2} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
BUG=chromium:318206 TBR=jochen@chromium.org, machenbach@chromium.org LOG=n NOTRY=true NOPRESUBMIT=true Change-Id: I23869d1c27c39e940bf30664e7d4d6f5eb92b58d Reviewed-on: https://chromium-review.googlesource.com/715764 Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#3} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ib7b011eeb7ffd1ab55559559fc2399d5ec0fa68c Reviewed-on: https://chromium-review.googlesource.com/716236 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#4} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
Revision: a445b97 Should fix build problem on 6.3. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=machenbach@chromium.org Change-Id: I8c679afc5003ebe3ccae926e7a752fa1f9e67bd7 Reviewed-on: https://chromium-review.googlesource.com/716225 Reviewed-by: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#5} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I3867c48296c3c5d5f636d35e3cfd0376b433c7c1 Reviewed-on: https://chromium-review.googlesource.com/716237 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#6} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
This reverts commit d9a2584. This is for 6.3 branch (to go with Chromium 63 branch). Reason for revert: I'm reverting this CL for a few reasons. #2 is the most significant and I should have thought of that before making a switch. Sorry for that. 1) perf-regression: http://crbug.com/769706 2) http://crbug.com/612010 : ICU timezone update is not propagated to zygote process so that new tabs will hold on to an old timezone even after a timezone change on Linux and Chrome OS. 3) http://crbug.com/754053 : OS timezone detection issues on macOS 10.13, Ubutu 16, RHEL 7, SuSe Linux 12 or newer. ; it's being fixed. So, it actually ok. 4) http://crbug.com/771868 : timezone wrong in gmail: If it's due to Revision: 28ef8dc BUG=chromium:612010,chromium:769706,chromium:771868,v8:2137,v8:6031,v8:6076 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=adamk@chromium.org, hablich@chromium.org Change-Id: Id0093c2bc69e5bc1d3b7147b7bbcc633ed625a45 Reviewed-on: https://chromium-review.googlesource.com/721919 Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#7} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ib8890215f805bc52e0934b85d3148004d8905202 Reviewed-on: https://chromium-review.googlesource.com/721980 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#8} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
Revision: 69bd294 Merge to 6.3 branch - remove unused Runtime_GetLanguageTagVariants - add test for another related bug (chromium:770452) as well as for chromium:770450 . BUG=chromium:770450,chromium:770452 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=adamk@chromium.org Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Ia2c6dd2156c51995fb18228fc3062a86e78d719c Reviewed-on: https://chromium-review.googlesource.com/721844 Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#9} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0a6e5fbf8480961e228d48df9da3eccc9c1d2b21 Reviewed-on: https://chromium-review.googlesource.com/721981 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#10} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
…cts. Revision: 6aa9f43 BUG=chromium:763073 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org Change-Id: If8a8ebf9e176e862912010deb1a54ae484bd45e3 Reviewed-on: https://chromium-review.googlesource.com/722639 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#11} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
… bits). Revision: a803fad BUG=v8:6916 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org Change-Id: I4236e37ee9693bed3f4bb65e43b33d8da94cf634 Reviewed-on: https://chromium-review.googlesource.com/722640 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#12} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I7579594e7dafe60bfb2b65df09fb3425d8c04d40 Reviewed-on: https://chromium-review.googlesource.com/722082 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#13} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
Merged: [ic] Do access checks when storing via JSGlobalProxy. Revision: 5ea95fe Merged: [ic] Fix storing to JSGlobalProxy having JSProxy in prototype chain. Revision: b19a1ba BUG=chromium:764219 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=verwaest@chromium.org Change-Id: Icc7dde6ba3faae1aee29c4f3ac1aaa27d94f3124 Reviewed-on: https://chromium-review.googlesource.com/721443 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#14} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I11f567e375bacb9c2774b2ecd9efb5792426021c Reviewed-on: https://chromium-review.googlesource.com/721943 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#15} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
Parser creates a FunctionState for default ctors, which affects the next_function_is_likely_called logic. PreParser needs to match that logic, so that Parser and PreParser agree about which functions are skippable. BUG=v8:5515, chromium:773576 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I96cb6f5aa68e74389a863355f70a34693a2d1329 Reviewed-on: https://chromium-review.googlesource.com/712579 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#48511}(cherry picked from commit dd18faf) Reviewed-on: https://chromium-review.googlesource.com/723519 Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#16} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
This reverts commit 593b0d8. Reason for revert: broke some branch builders like https://build.chromium.org/p/client.v8.branches/builders/V8%20arm%20-%20sim%20-%20beta%20branch%20-%20debug Original change's description: > Merged: Correct the misuse of uloc_{to,from}LanguageTag > > Revision: 69bd294 > > Merge to 6.3 branch > > - remove unused Runtime_GetLanguageTagVariants > - add test for another related bug (chromium:770452) as well as for > chromium:770450 . > > BUG=chromium:770450,chromium:770452 > LOG=N > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > R=adamk@chromium.org > > Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng > Change-Id: Ia2c6dd2156c51995fb18228fc3062a86e78d719c > Reviewed-on: https://chromium-review.googlesource.com/721844 > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Jungshik Shin <jshin@chromium.org> > Cr-Commit-Position: refs/branch-heads/6.3@{#9} > Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} > Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432} TBR=adamk@chromium.org,hablich@chromium.org,jshin@chromium.org Change-Id: I37018f8241efe1431f453ff55cf8216a5daa66de No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:770450, chromium:770452 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/723323 Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#17} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
This reverts commit d734370. Reason for revert: broke some branch builders like https://build.chromium.org/p/client.v8.branches/builders/V8%20arm%20-%20sim%20-%20beta%20branch%20-%20debug Original change's description: > Merged: Revert "Enable icu-timezone-data by default" > > This reverts commit d9a2584. > This is for 6.3 branch (to go with Chromium 63 branch). > > Reason for revert: > > I'm reverting this CL for a few reasons. #2 is the most significant and > I should have thought of that before making a switch. Sorry for that. > > 1) perf-regression: http://crbug.com/769706 > 2) http://crbug.com/612010 : ICU timezone update is not propagated to > zygote process so that new tabs will hold on to an old timezone even > after a timezone change on Linux and Chrome OS. > > 3) http://crbug.com/754053 : OS timezone detection issues on macOS > 10.13, Ubutu 16, RHEL 7, SuSe Linux 12 or newer. ; it's being fixed. So, > it actually ok. > > 4) http://crbug.com/771868 : timezone wrong in gmail: If it's due to > > Revision: 28ef8dc > > BUG=chromium:612010,chromium:769706,chromium:771868,v8:2137,v8:6031,v8:6076 > LOG=N > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > R=adamk@chromium.org, hablich@chromium.org > > Change-Id: Id0093c2bc69e5bc1d3b7147b7bbcc633ed625a45 > Reviewed-on: https://chromium-review.googlesource.com/721919 > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Jungshik Shin <jshin@chromium.org> > Cr-Commit-Position: refs/branch-heads/6.3@{#7} > Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} > Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432} TBR=adamk@chromium.org,hablich@chromium.org,jshin@chromium.org Change-Id: I8b30f8f9c63b93cb000facbf910ed111ca3f9ab2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:612010, chromium:769706, chromium:771868, v8:2137, v8:6031, v8:6076 Reviewed-on: https://chromium-review.googlesource.com/723324 Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#18} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I81602ad8b9219df514418f0f8a9368c0a39183f5 Reviewed-on: https://chromium-review.googlesource.com/723700 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#19} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
…t32Key. Revision: a3de183 BUG=chromium:774459 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=cbruni@chromium.org Change-Id: Ia785eaaa6effe18f31ec59fdb9544ffc36b5195f Reviewed-on: https://chromium-review.googlesource.com/723593 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#20} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
This reverts commit 3b1cfa3. Reason for revert: ICU was not rolled in 6.3 branch leading invalid-locale test failure (that was added to test an ICU fix). Now, ICU is rolled in 6.3 branch ( https://chromium-review.googlesource.com/c/v8/v8/+/723564 ). Original change's description: > Revert "Merged: Revert "Enable icu-timezone-data by default"" > > This reverts commit d734370. > > Reason for revert: broke some branch builders like https://build.chromium.org/p/client.v8.branches/builders/V8%20arm%20-%20sim%20-%20beta%20branch%20-%20debug > > Original change's description: > > Merged: Revert "Enable icu-timezone-data by default" > > > > This reverts commit d9a2584. > > This is for 6.3 branch (to go with Chromium 63 branch). > > > > Reason for revert: > > > > I'm reverting this CL for a few reasons. #2 is the most significant and > > I should have thought of that before making a switch. Sorry for that. > > > > 1) perf-regression: http://crbug.com/769706 > > 2) http://crbug.com/612010 : ICU timezone update is not propagated to > > zygote process so that new tabs will hold on to an old timezone even > > after a timezone change on Linux and Chrome OS. > > > > 3) http://crbug.com/754053 : OS timezone detection issues on macOS > > 10.13, Ubutu 16, RHEL 7, SuSe Linux 12 or newer. ; it's being fixed. So, > > it actually ok. > > > > 4) http://crbug.com/771868 : timezone wrong in gmail: If it's due to > > > > Revision: 28ef8dc > > > > BUG=chromium:612010,chromium:769706,chromium:771868,v8:2137,v8:6031,v8:6076 > > LOG=N > > NOTRY=true > > NOPRESUBMIT=true > > NOTREECHECKS=true > > R=adamk@chromium.org, hablich@chromium.org > > > > Change-Id: Id0093c2bc69e5bc1d3b7147b7bbcc633ed625a45 > > Reviewed-on: https://chromium-review.googlesource.com/721919 > > Reviewed-by: Adam Klein <adamk@chromium.org> > > Commit-Queue: Jungshik Shin <jshin@chromium.org> > > Cr-Commit-Position: refs/branch-heads/6.3@{#7} > > Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} > > Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432} > > TBR=adamk@chromium.org,hablich@chromium.org,jshin@chromium.org > > Change-Id: I8b30f8f9c63b93cb000facbf910ed111ca3f9ab2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:612010, chromium:769706, chromium:771868, v8:2137, v8:6031, v8:6076 > Reviewed-on: https://chromium-review.googlesource.com/723324 > Reviewed-by: Michael Hablich <hablich@chromium.org> > Commit-Queue: Michael Hablich <hablich@chromium.org> > Cr-Commit-Position: refs/branch-heads/6.3@{#18} > Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} > Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432} TBR=adamk@chromium.org,hablich@chromium.org,jshin@chromium.org Change-Id: I8f712f1e6eb1f14c703ffe9f1d63d23b4b4bb08e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:612010, chromium:769706, chromium:771868, v8:2137, v8:6031, v8:6076 Reviewed-on: https://chromium-review.googlesource.com/723962 Reviewed-by: Michael Hablich <hablich@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#21} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
There are only two changes in the roll. This is to match Chromium M63's ICU in v8's 6.3 branch https://chromium.googlesource.com/chromium/deps/icu/+log/08cb9568..21d33b1a Bug: 770452 Test: See the bug Change-Id: I63007a5ece0222374a02a958bb04a523f66c78c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/723564 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#22} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
…ag"" This reverts commit 9a132a9. Reason for revert: ICU was not rolled in 6.3 branch leading invalid-locale test failure (that was added to test an ICU fix). Now, ICU is rolled in 6.3 branch ( https://chromium-review.googlesource.com/c/v8/v8/+/723564 ). Original change's description: > Revert "Merged: Correct the misuse of uloc_{to,from}LanguageTag" > > This reverts commit 593b0d8. > > Reason for revert: broke some branch builders like https://build.chromium.org/p/client.v8.branches/builders/V8%20arm%20-%20sim%20-%20beta%20branch%20-%20debug > > Original change's description: > > Merged: Correct the misuse of uloc_{to,from}LanguageTag > > > > Revision: 69bd294 > > > > Merge to 6.3 branch > > > > - remove unused Runtime_GetLanguageTagVariants > > - add test for another related bug (chromium:770452) as well as for > > chromium:770450 . > > > > BUG=chromium:770450,chromium:770452 > > LOG=N > > NOTRY=true > > NOPRESUBMIT=true > > NOTREECHECKS=true > > R=adamk@chromium.org > > > > Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng > > Change-Id: Ia2c6dd2156c51995fb18228fc3062a86e78d719c > > Reviewed-on: https://chromium-review.googlesource.com/721844 > > Reviewed-by: Adam Klein <adamk@chromium.org> > > Commit-Queue: Jungshik Shin <jshin@chromium.org> > > Cr-Commit-Position: refs/branch-heads/6.3@{#9} > > Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} > > Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432} > > TBR=adamk@chromium.org,hablich@chromium.org,jshin@chromium.org > > Change-Id: I37018f8241efe1431f453ff55cf8216a5daa66de > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:770450, chromium:770452 > Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/723323 > Reviewed-by: Michael Hablich <hablich@chromium.org> > Commit-Queue: Michael Hablich <hablich@chromium.org> > Cr-Commit-Position: refs/branch-heads/6.3@{#17} > Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} > Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432} TBR=adamk@chromium.org,hablich@chromium.org,jshin@chromium.org Change-Id: Ie7eac96859c8053c4f1b41b0a9b4f79a44883295 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:770450, chromium:770452 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/723608 Reviewed-by: Michael Hablich <hablich@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#23} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: If830953f0ced61f8470d1d1faf1956fffffd39c5 Reviewed-on: https://chromium-review.googlesource.com/724982 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#24} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
…sing. When skipping inner funcs is enabled, we also track variables for top level funcs. Thus, we also declared the function name for the function scope, even though it was the function scope for a function whose preparsing was aborted. This lead into declaring the function name twice. The fix is to declare the function name only in the success case. The code was "wrong" before too, but this was never a problem, since variable tracking and aborting preparsing were enabled for disjoint sets of functions (aborting preparsing only for top-level, and variable tracking for non-top-level). BUG=v8:5516,chromium:774475 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: Ie6c321cc834cd946e8843f73916fa7dd75e9cd09 Reviewed-on: https://chromium-review.googlesource.com/720920 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#48592}(cherry picked from commit d69159d) Reviewed-on: https://chromium-review.googlesource.com/728000 Reviewed-by: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#25} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
Inner functions which called eval, and were the kind of functions that can use `super`, were erroneously not marked as "uses_super_property", leading to downstream crashes when the runtime tried to load the [[HomeObject]] from them. This patch eliminates the public Scope::uses_super_property() API and ensures that callers always call Scope::NeedsHomeObject() instead. This is a minimal fix designed for easy merging; it's likely that in the long run we should remove most mentions of "uses super property" and replace them with "needs home object" for clarity. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: v8:5516, chromium:774994 Change-Id: Id269dd33e35bd40f6b59a3d3e19330687afa64f8 Reviewed-on: https://chromium-review.googlesource.com/721879 Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#48619}(cherry picked from commit 94a71d7) Reviewed-on: https://chromium-review.googlesource.com/727762 Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#26} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I5008b819ac6a5b89af2f8981268d6364bc545b66 Reviewed-on: https://chromium-review.googlesource.com/728040 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#27} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
This cherry-picks: https://chromium-review.googlesource.com/c/v8/v8/+/725706 https://chromium-review.googlesource.com/c/v8/v8/+/727800 https://chromium-review.googlesource.com/c/v8/v8/+/728023 NOTRY=true NOPRESUBMIT=true Bug: v8:6917 Change-Id: If89a30f9d6548d9402ebad6bcef5b0d5f50802b2 Reviewed-on: https://chromium-review.googlesource.com/727205 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#28} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ife4392a3dd9e6ca19a71fa23927e23f8b52b41f2 Reviewed-on: https://chromium-review.googlesource.com/727943 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#29} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Change-Id: I4b55c51a57e10e493e20b852c37a747bf897f33e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4514944 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.3@{v8#21} Cr-Branched-From: b0a3a06-refs/heads/11.3.244@{#1} Cr-Branched-From: 0326cf6-refs/heads/main@{#86647}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jun 24, 2023
Change-Id: I6c85f519fd2970bd77861e5a6ee7ea0bedeb377c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4640493 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.5@{v8#21} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jul 25, 2023
Change-Id: I198e11351d477b327853861ac5d79f390e2d4567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4711108 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.6@{v8#21} Cr-Branched-From: e29c028-refs/heads/11.6.189@{v8#3} Cr-Branched-From: 95cbef2-refs/heads/main@{#88340}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Sep 3, 2023
Change-Id: I829b1ee090c4420faa765e8b3b8da94fb6e9f8f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4820409 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.7@{v8#21} Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1} Cr-Branched-From: aeb4552-refs/heads/main@{#89415}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Oct 1, 2023
Change-Id: Ib19f8f4755369517b7ae0f9098783ca1c061341e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4898729 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.8@{v8#21} Cr-Branched-From: 935bdbf-refs/heads/11.8.172@{#1} Cr-Branched-From: b82a911-refs/heads/main@{#89779}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Dec 17, 2023
Change-Id: I98d725f25fe3c407d7235b3a6b90c9eb4a40fe9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5115359 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.1@{v8#21} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Dec 17, 2023
Change-Id: I504556db58c3c803609ef8483024b568def10da6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5115700 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.0@{v8#21} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Feb 4, 2024
Change-Id: I66e8d236dea18056b67532b04980ff36cae34676 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249163 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.2@{v8#21} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot
pushed a commit
that referenced
this pull request
Mar 20, 2024
Change-Id: I45ed439b8a983721183f534771ff908bf7d47b98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5383412 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.3@{#21} Cr-Branched-From: a86e197-refs/heads/12.3.219@{#1} Cr-Branched-From: 21869f7-refs/heads/main@{#92385}
hubot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Change-Id: I6c5a39690dc315316fe4ded61c8728d247c4eaa9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5438473 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.4@{#21} Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1} Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}
hubot
pushed a commit
that referenced
this pull request
May 22, 2024
Change-Id: I37f1ebd988814cfe07c18c49c3616fee25cfb564 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5554344 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.5@{#21} Cr-Branched-From: 15b9756-refs/heads/12.5.227@{#1} Cr-Branched-From: 497d857-refs/heads/main@{#93350}
hubot
pushed a commit
that referenced
this pull request
Jun 6, 2024
Change-Id: Ia08b7cf2e3867ca910aec04b0552c9f475e689c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5597110 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.6@{#21} Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2} Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot
pushed a commit
that referenced
this pull request
Jul 3, 2024
Change-Id: Id34787a4dcc8ce26a24947787aeabe565da81546 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5675264 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.7@{#21} Cr-Branched-From: 35cc908-refs/heads/12.7.224@{#1} Cr-Branched-From: 6d60e67-refs/heads/main@{#94324}
hubot
pushed a commit
that referenced
this pull request
Aug 13, 2024
Change-Id: Ic733272640fa613ada20eecb357e41827c680592 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5784194 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.8@{#21} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Change-Id: Ibd2f17a5f01c5f317b653da50933fdeed36da042 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5835919 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.9@{#21} Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1} Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot
pushed a commit
that referenced
this pull request
Sep 26, 2024
Stack walks expect the receiver and closure to be materialized. Bug: 368311899 (cherry picked from commit 6b455eb) Change-Id: I91a4ad3f38bd2afa174bf11bc10389bc573c983e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5893175 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/branch-heads/13.0@{#21} Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1} Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot
pushed a commit
that referenced
this pull request
Nov 26, 2024
Version incremented at https://cr-buildbucket.appspot.com/build/8730201909973390753 Change-Id: If50c9a3299eb3d2aeced79252e36b9c5bdc14cd2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6051161 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.1@{#21} Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1} Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}
hubot
pushed a commit
that referenced
this pull request
Nov 26, 2024
Version incremented at https://cr-buildbucket.appspot.com/build/8730190961506292257 Change-Id: I8478d977d332b9f3d8fb838e46b162e923044358 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6051410 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.2@{#21} Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1} Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot
pushed a commit
that referenced
this pull request
Jan 17, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8725489545595243937 Change-Id: Ib6cd25438108d7b55917d4660c9230fdbcc9fa01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6180213 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.3@{#21} Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1} Cr-Branched-From: 3348638-refs/heads/main@{#97937}
hubot
pushed a commit
that referenced
this pull request
Feb 14, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8722942072212213105 Change-Id: Id4d83ee9d7bee8a051af43d6609cc253f0cccff9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6269838 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.4@{#21} Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1} Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8716361146461993345 Change-Id: I2196ebf39a89e394cce351c72a528107b8e025a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6494192 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.5@{#21} Cr-Branched-From: c206c46-refs/heads/13.5.212@{#1} Cr-Branched-From: af3cadc-refs/heads/main@{#99020}
hubot
pushed a commit
that referenced
this pull request
May 15, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8714791365951314881 Change-Id: I193f91bcf6126b2ecfbe01be6e8b3d862fa4bda3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6551884 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.6@{#21} Cr-Branched-From: 04fa9cb-refs/heads/13.6.233@{#1} Cr-Branched-From: f6be482-refs/heads/main@{#99571}
hubot
pushed a commit
that referenced
this pull request
May 29, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8713584537672014705 Change-Id: I25afd538d27a6485e71ddf918d4d58005d783cb7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6598286 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.7@{#21} Cr-Branched-From: dd5370d-refs/heads/13.7.152@{#1} Cr-Branched-From: fa9b753-refs/heads/main@{#99927}
hubot
pushed a commit
that referenced
this pull request
Jun 5, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8712879391462833585 Change-Id: Ib11db221497ff0212ebf372eb86223799a9da3b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6624399 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.8@{#21} Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1} Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot
pushed a commit
that referenced
this pull request
Jul 14, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8709380461040155553 Change-Id: I1850991a4e07fcdb632b044a6661fcb61113d196 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6734119 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.9@{#21} Cr-Branched-From: 76ea409-refs/heads/13.9.205@{#1} Cr-Branched-From: 2824212-refs/heads/main@{#100941}
hubot
pushed a commit
that referenced
this pull request
Sep 22, 2025
While the memory buffer itself is managed off-heap, this builtin can allocate on-heap. (cherry picked from commit 5dd4e7c) Fixed: 445870128 Change-Id: I17934703aa14ca9baa3dd14246c2cbc1bb596e15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6973488 Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Cr-Commit-Position: refs/branch-heads/14.1@{#21} Cr-Branched-From: 1f4839b-refs/heads/14.1.146@{#1} Cr-Branched-From: cd6944c-refs/heads/main@{#102149}
hubot
pushed a commit
that referenced
this pull request
Oct 21, 2025
Expect()/ExpectNext() used to simply set the cursor to the end of the input if the expectation failed. The issue is that a failed expectation can trigger a GC due to allocation of the Exception object. To avoid surprises, Expect() and ExpectNext() now return a bool value indicating if the expectation failed. Checking of this value is enforced and all current usages are replaced by a Macro that returns early if an exception was thrown. Drive-by: Also force checking the return value of Check(). Fixed: 452296415 (cherry picked from commit 50eba5e) Change-Id: Ica951ecda9052e37f68b01293d245c8c2533694e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7062140 Auto-Submit: Patrick Thier <pthier@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/branch-heads/14.2@{#21} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
hubot
pushed a commit
that referenced
this pull request
Nov 11, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8698499955574318401 Change-Id: Idc6aa85ea955cbeb114d620417ab81b3f881d98d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7139188 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.3@{#21} Cr-Branched-From: 13c7e31-refs/heads/14.3.127@{#1} Cr-Branched-From: 01af089-refs/heads/main@{#103352}
hubot
pushed a commit
that referenced
this pull request
Dec 15, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8695434946212478017 Change-Id: Ief107fe362a803ed1f3ca802631cdebaaa2ae9f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7260474 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.4@{#21} Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1} Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mpszone