Feat: add queryStrategy option for DNS#749
Closed
Loyalsoldier wants to merge 9 commits intov2fly:masterfrom
Loyalsoldier:dns-queryStrategy
Closed
Feat: add queryStrategy option for DNS#749Loyalsoldier wants to merge 9 commits intov2fly:masterfrom Loyalsoldier:dns-queryStrategy
Loyalsoldier wants to merge 9 commits intov2fly:masterfrom
Loyalsoldier:dns-queryStrategy
Conversation
kslr
reviewed
Mar 8, 2021
|
|
||
| // SetFakeDNSOption sets FakeEnable option for DNS client. | ||
| SetFakeDNSOption(isFakeEnable bool) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
不然怎么动态设置 DNS Client 的查询参数呢？🤔
Contributor
There was a problem hiding this comment.
禁止修改V2Ray的v2ray:api:stable接口。你加接口的话也要保证对于没实现这个接口的实现也可以运行。
xiaokangwang
requested changes
Mar 8, 2021
Contributor
xiaokangwang
left a comment
There was a problem hiding this comment.
这个修改太魔改了，如果你需要这个功能我可以帮你写，但是如果你写的话需要保证
- 不要进行破坏性修改：不要修改已有接口，保证任何一个实现已有接口的第三方实现可以继续正常运行
- 不要破坏兼容性： reserve的字段不能再被使用。
之前的魔改修改接口为我就很难受，正准备想办法给回滚回去。
|
|
||
| // SetFakeDNSOption sets FakeEnable option for DNS client. | ||
| SetFakeDNSOption(isFakeEnable bool) | ||
|
|
Contributor
There was a problem hiding this comment.
禁止修改V2Ray的v2ray:api:stable接口。你加接口的话也要保证对于没实现这个接口的实现也可以运行。
| string tag = 6; | ||
|
|
||
| reserved 7; | ||
| QueryStrategy query_strategy = 7; |
Contributor
|
这里正确的实现方法是新加一个接口，然后用类型断言来确定是否实现了新的接口，如果实现了就用新接口。而不是通过改已有接口来实现功能。如果需要的话我可以直接连上次的因为fakedns什么的改的接口一起给改回去。 |
Contributor
Author
请展示真正的技术 😋 😀 |
Contributor
|
好！昨天那么说有点抱歉，实在是看见这种修改有点难受上头了。。。 |
ttrobot0101
pushed a commit
to ttrobot0101/v2ray-core
that referenced
this pull request
Aug 17, 2025
Update workflows PS: `Submit to winget` has no test, because we need next tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #482