Skip to content

feat(install): improve robustness, error handling, and internationalization #9451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
naoNao89 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(install): improve robustness, error handling, and internationalization #9451

naoNao89 wants to merge 1 commit into from

Conversation

@naoNao89
Copy link
Contributor

@naoNao89 naoNao89 commented Nov 22, 2025

  1. Safe argument validation (prevents panics)
  2. Signal exit codes per POSIX (128+signal)
  3. Full i18n (all debug messages translated)

GNU compliant: https://man7.org/linux/man-pages/man1/install.1.html
Covers error paths, maintains backward compatibility.

@naoNao89 naoNao89 mentioned this pull request Nov 22, 2025
Open
10 tasks
@github-actions
Copy link

github-actions bot commented Nov 23, 2025

GNU testsuite comparison:

GNU test failed: tests/install/install-Z-selinux. tests/install/install-Z-selinux is passing on 'main'. Maybe you have to rebase?

@naoNao89 naoNao89 force-pushed the feature/install-strip-safe-handling branch 2 times, most recently from af032d4 to 4bc9b8d Compare November 23, 2025 00:43
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 23, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9451 will not alter performance

Comparing naoNao89:feature/install-strip-safe-handling (f0feb98) with main (b3d05b6)1

Summary

✅ 127 untouched
⏩ 6 skipped2

Footnotes

  1. No successful run was found on main (f43602d) during the generation of this report, so b3d05b6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Nov 23, 2025

GNU testsuite comparison:

GNU test failed: tests/install/install-Z-selinux. tests/install/install-Z-selinux is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@naoNao89 naoNao89 force-pushed the feature/install-strip-safe-handling branch from 4bc9b8d to 95dddc4 Compare November 23, 2025 03:11
@github-actions
Copy link

github-actions bot commented Nov 23, 2025

GNU testsuite comparison:

GNU test failed: tests/install/install-Z-selinux. tests/install/install-Z-selinux is passing on 'main'. Maybe you have to rebase?

@naoNao89 naoNao89 force-pushed the feature/install-strip-safe-handling branch from 95dddc4 to 6838756 Compare November 23, 2025 11:25
@github-actions
Copy link

github-actions bot commented Nov 23, 2025

GNU testsuite comparison:

GNU test failed: tests/install/install-Z-selinux. tests/install/install-Z-selinux is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@naoNao89 naoNao89 force-pushed the feature/install-strip-safe-handling branch from 6838756 to 94ca85a Compare November 23, 2025 14:28
@github-actions
Copy link

github-actions bot commented Nov 23, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@naoNao89 naoNao89 force-pushed the feature/install-strip-safe-handling branch 2 times, most recently from 661e57f to 625440b Compare December 30, 2025 05:19
@naoNao89
feat(install): add --debug flag, improve error handling and i18n debu…
f0feb98 
…g messages; refactor to let-else; update tests
@naoNao89 naoNao89 force-pushed the feature/install-strip-safe-handling branch from 625440b to f0feb98 Compare December 30, 2025 07:04
@sylvestre
Copy link
Contributor

sylvestre commented Dec 30, 2025

this pr is doing too many things in parallel
it is possible to split it a bit ? thanks

@naoNao89
Copy link
Contributor Author

naoNao89 commented Dec 30, 2025

i don't know why i rebased from upstream, but it always uses my fork, and my fork doesn't have these on the main branch

@naoNao89
Copy link
Contributor Author

naoNao89 commented Dec 30, 2025

hmm, the PR shows 11 commits only on the browser, after used Ctrl + Shift + R, and now it only shows 1 commit. The gh command also shows just 1 commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@naoNao89 @sylvestre