Skip to content

printf: Make printf operate on bytes instead of strings #6028

Merged
cakebaker merged 3 commits intouutils:mainfrom
RenjiSann:feature/printf-byte
Feb 29, 2024
Merged

printf: Make printf operate on bytes instead of strings #6028
cakebaker merged 3 commits intouutils:mainfrom
RenjiSann:feature/printf-byte

Conversation

@RenjiSann
Copy link
Copy Markdown
Collaborator

@RenjiSann RenjiSann commented Feb 28, 2024

Fixes #5826

Reference

❯ /bin/printf %c 🙃 | hexdump          
0000000 00f0                                   
0000001

Before

❯ ./target/debug/printf %c 🙃 | hexdump
0000000 b0c3                                   
0000002

After

❯ ./target/debug/printf %c 🙃 | hexdump 
0000000 00f0                                   
0000001

@RenjiSann
Copy link
Copy Markdown
Collaborator Author

RenjiSann commented Feb 28, 2024

@tertsdiepraam @cakebaker

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 29, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker mentioned this pull request Feb 29, 2024
Closed
@cakebaker cakebaker merged commit 75b2bfb into uutils:main Feb 29, 2024
@cakebaker
Copy link
Copy Markdown
Contributor

cakebaker commented Feb 29, 2024

Thanks for your PR :)

@RenjiSann RenjiSann deleted the feature/printf-byte branch February 29, 2024 18:02
@chenrui333 chenrui333 mentioned this pull request Mar 24, 2024
Merged
@moonfruit moonfruit mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

printf should print a byte instead of a char

2 participants

@RenjiSann @cakebaker