chmod: Fix chmod -c --reference reporting when no change is made#6016
Merged
cakebaker merged 5 commits intouutils:mainfrom Feb 26, 2024
Merged
chmod: Fix chmod -c --reference reporting when no change is made#6016cakebaker merged 5 commits intouutils:mainfrom
cakebaker merged 5 commits intouutils:mainfrom
Conversation
Collaborator
|
Is it possible to add a test for this? :) |
Contributor
Author
|
@BenWiederhake yep! It also failed a test beforehand so I kind of flipped the logic: made the reference permission 4 octals long, just as the others. |
|
GNU testsuite comparison: |
cakebaker
approved these changes
Feb 26, 2024
Contributor
|
Thanks for your PR! |
ysthakur
pushed a commit
to ysthakur/coreutils
that referenced
this pull request
Feb 27, 2024
…ils#6016) * Make fperm hold 6 digit octal permission. Set it to 4 digits when displaying * Add test * Make every permission 4 octal digits * Change test name to be more suggestive * chmod: merge two args in test --------- Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #6009.
I changed the code so that the old permission octal is retrieved in "full form" (6 octal digits). It is afterwards set to 4 digits when displayed.
Beforehand, 2 identical permissions were marked as different because of the different formats, resulting in incorrect displays for
-c.