uniq: pass remaining GNU tests#5994
Merged
sylvestre merged 7 commits intouutils:mainfrom Feb 25, 2024
Merged
Conversation
sylvestre
reviewed
Feb 21, 2024
sylvestre
reviewed
Feb 21, 2024
|
GNU testsuite comparison: |
Contributor
Author
|
@sylvestre checking in to see if you have any other comments / suggestions on this PR |
sylvestre
reviewed
Feb 25, 2024
| //! | ||
| use std::env; | ||
|
|
||
| pub const OBSOLETE: usize = 199209; |
Contributor
There was a problem hiding this comment.
what about using an enum here?
Contributor
Author
There was a problem hiding this comment.
yes, initially i tried to implement it as an enum, but discarded in favor of these constants - unfortunately it is inconsistently checked in GNU, so was easier to implement this way for now. Might need to give it another try later on as these will be needed to fully cover GNU tests for at least 2 more utilities
Contributor
|
Impressive work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes in order to pass GNU
tests/uniq/uniq.pl:split. Unfortunately it is not possible to implement it with just Clap for all required test casesposixwith 3 constants and a single function to return POSIX version based on_POSIX2_VERSIONenvironment variable. This module would be needed to add similar functionality tosort,tailandtouchlater on (most likely to finalize their GNU tests compliance as well)u8bytes sequence. This is required to pass GNUschartest case and in general aligns the behavior with GNU versionShould also fix #3509