Skip to content

fix tr with delete flag if more than 1 operand given #5945

Merged
cakebaker merged 5 commits intouutils:mainfrom
BaherSalama:main
Feb 6, 2024
Merged

fix tr with delete flag if more than 1 operand given #5945
cakebaker merged 5 commits intouutils:mainfrom
BaherSalama:main

Conversation

@BaherSalama
Copy link
Copy Markdown
Contributor

@BaherSalama BaherSalama commented Feb 5, 2024

fixes the issue #5944 where tr -d flag should not take more than one operand
so its like this now

❯ echo "acsd5c"| ./target/debug/tr -d "c"
asd5

~/sad/coreutils main
❯ echo "acsd5c"| ./target/debug/tr -d "c" "p"
./target/debug/tr: extra operand 'p'
Only one string may be given when deleting without squeezing repeats.
Try './target/debug/tr --help' for more information.

problem tho is that adding more arguments errors out tr when it should just display the same massage

where gnu tr

❯ echo "acsd5c"| tr -d "c" "p" "m"
tr: extra operand ‘p’
Try 'tr --help' for more information.

coreutils one

❯ echo "acsd5c"| ./target/debug/tr -d "c" "p" "m"
error: unexpected value 'm' for '[sets]...' found; no more were expected

Usage: ./target/debug/tr [OPTION]... SET1 [SET2]

For more information, try '--help'.

not sure this is related to #5944 since i could not grep for the error expect in whom test so don't know where to look for that

@cakebaker cakebaker changed the title fix tr with delete flag if more than 1 oprerand given fix tr with delete flag if more than 1 operand given Feb 5, 2024
@cakebaker cakebaker linked an issue Feb 5, 2024 that may be closed by this pull request
tr -d should reject a second argument #5944
Closed
@sylvestre
Copy link
Copy Markdown
Contributor

sylvestre commented Feb 5, 2024

looks good but could you please add a test to make sure we don't regress in the future ?
thanks

@BaherSalama
Copy link
Copy Markdown
Contributor Author

BaherSalama commented Feb 5, 2024

added a test for 2 operands with -d flag

@cakebaker cakebaker merged commit 5c2ae5b into uutils:main Feb 6, 2024
@cakebaker
Copy link
Copy Markdown
Contributor

cakebaker commented Feb 6, 2024

Thanks for your PR :)

@cakebaker cakebaker mentioned this pull request Feb 6, 2024
Closed
ysthakur pushed a commit to ysthakur/coreutils that referenced this pull request Feb 27, 2024
@BaherSalama @cakebaker @ysthakur
fix tr with delete flag if more than 1 operand given (uutils#5945)
4304467 
* fix tr

* fix

* adding a test

* tr: rename test function

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
@chenrui333 chenrui333 mentioned this pull request Mar 24, 2024
Merged
@moonfruit moonfruit mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tr -d should reject a second argument

3 participants

@BaherSalama @sylvestre @cakebaker