more: Disable raw mode before exiting if a panic occurs#5914
Merged
cakebaker merged 1 commit intouutils:mainfrom Feb 1, 2024
Merged
more: Disable raw mode before exiting if a panic occurs#5914cakebaker merged 1 commit intouutils:mainfrom
cakebaker merged 1 commit intouutils:mainfrom
Conversation
Collaborator
|
I'm not really opposed to this, but I'd rather see the panics fixed instead. I want it to be possible to compile the coreutils with |
Contributor
Author
|
If I understand correctly, if I remove the panic inside the hook then when the code panics, it will first execute the set_hook and then execute the |
Collaborator
|
You're right, I was confused 😅 |
f9cf7e9 to
4ff6a45
Compare
Contributor
Author
|
I have made some small changes to the code. First, I have removed the panic. Secondly, I put a |
4ff6a45 to
b9112da
Compare
|
GNU testsuite comparison: |
Contributor
|
Thanks :) Btw: You can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a panic occurs, the raw mode is still active, requiring the terminal to be closed and reopened to use it again.
To test the fix, execute the following command without the new panic hook:
./target/debug/coreutils more -n 2 cargo-test.md cargo-test.mdThe terminal should be unusable after running this command.
Then, execute the command with the new panic hook:
./target/debug/coreutils more -n 2 cargo-test.md cargo-test.mdThe terminal should remain usable after running this command.