Skip to content

CI: test uucore with coreutils in codecov to run it with the proper features#5825

Merged
sylvestre merged 2 commits intouutils:mainfrom
tertsdiepraam:codecov-uucore-features
Jan 17, 2024
Merged

CI: test uucore with coreutils in codecov to run it with the proper features#5825
sylvestre merged 2 commits intouutils:mainfrom
tertsdiepraam:codecov-uucore-features

Conversation

@tertsdiepraam
Copy link
Copy Markdown
Collaborator

@tertsdiepraam tertsdiepraam commented Jan 10, 2024

I think this should fix https://github.com/uutils/coreutils/pull/5783/files#r1447343162

The problem is that we were testing uucore without any features enabled, which led to a lot of tests being ignored.

In general it might be time to refactor our workflows a bit and make them a bit more uniform. The MSRV, codecov and regular builds all seem to be doing slightly different things.

@tertsdiepraam tertsdiepraam mentioned this pull request Jan 10, 2024
Merged
@sylvestre
Copy link
Copy Markdown
Contributor

sylvestre commented Jan 10, 2024

Nice: codecov/project Successful in 1s — 85.67% (+0.38%) compared to cd9863d

@sylvestre
Copy link
Copy Markdown
Contributor

sylvestre commented Jan 10, 2024

I guess you saw:


error[E0432]: unresolved import `crate::digest`
   --> src\uucore\src/lib\features\sum.rs:487:20
    |
487 |         use crate::digest::Digest;
    |                    ^^^^^^
    |                    |
    |                    unresolved import
    |                    help: a similar path exists: `md5::digest`

error[E0432]: unresolved import `crate::digest`
   --> src\uucore\src/lib\features\sum.rs:488:20
    |
488 |         use crate::digest::DigestWriter;
    |                    ^^^^^^
    |                    |
    |                    unresolved import
    |                    help: a similar path exists: `md5::digest`

@sylvestre
Copy link
Copy Markdown
Contributor

sylvestre commented Jan 14, 2024

@tertsdiepraam ping ? :)

@tertsdiepraam
Copy link
Copy Markdown
Collaborator Author

tertsdiepraam commented Jan 17, 2024

Let's see :)

@tertsdiepraam
Copy link
Copy Markdown
Collaborator Author

tertsdiepraam commented Jan 17, 2024

@sylvestre seems to be good now :)

@sylvestre sylvestre merged commit b7a14ac into uutils:main Jan 17, 2024
cakebaker added a commit to cakebaker/coreutils that referenced this pull request Jan 18, 2024
@cakebaker
ci: undo part of uutils#5825
df745d0
@cakebaker cakebaker mentioned this pull request Jan 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tertsdiepraam @sylvestre