install: support when a hyphen is passed#5697
Merged
sylvestre merged 3 commits intouutils:mainfrom Dec 23, 2023
sylvestre:hiphen
Merged
install: support when a hyphen is passed#5697sylvestre merged 3 commits intouutils:mainfrom sylvestre:hiphen
sylvestre merged 3 commits intouutils:mainfrom
sylvestre:hiphen
Conversation
Should fix: tests/install/strip-program.sh
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 23, 2023
cakebaker
reviewed
Dec 23, 2023
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
cakebaker
approved these changes
Dec 23, 2023
Contributor
cakebaker
left a comment
There was a problem hiding this comment.
Did you notice that there is no output when running cargo run --features="unix" install -s --strip-program ./no-hyphen -- source -dest whereas GNU outputs ./-dest? Should I open a ticket for it?
Contributor
Author
|
yeah, probably :) |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix: tests/install/strip-program.sh